Fix RabbitMQ OCF script rely on the exit code then it is always 0

Bug #1506440 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Bogdan Dobrelya

Bug Description

1) The get_all_pacemaker_nodes() returns exit code 0, even then crm_node -l returned > 0:
https://github.com/stackforge/fuel-library/blob/master/files/fuel-ha-utils/ocf/rabbitmq#L497-L501
2) The check_timeouts() relies on the exid code result which is always 0:
https://github.com/stackforge/fuel-library/blob/master/files/fuel-ha-utils/ocf/rabbitmq#L1057

Tags: area-library
Changed in fuel:
importance: Undecided → High
milestone: none → 8.0
assignee: nobody → Bogdan Dobrelya (bogdando)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235336

Revision history for this message
Matthew Mosesohn (raytrac3r) wrote :

Lowering to medium. This bug doesn't reflect any actual failed deployments, but it definitely should get fixed.

Changed in fuel:
importance: High → Medium
Dmitry Pyzhov (dpyzhov)
tags: added: area-library
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/235336
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=cf02b81f21845087a328350cb95b8d1e90902cc0
Submitter: Jenkins
Branch: master

commit cf02b81f21845087a328350cb95b8d1e90902cc0
Author: Bogdan Dobrelya <email address hidden>
Date: Thu Oct 15 15:21:09 2015 +0200

    Fix piped exit codes expectations and count processing

    * Fix return code of the get_all_pacemaker_nodes() and
      get_alive_pacemaker_nodes_but() to be
      not provided as ignored anyway.
    * Fix return code expectation of the fetched count attribute
      in the check_timeouts().
    Upstream patch https://github.com/rabbitmq/rabbitmq-server/pull/374

    Closes-bug: #1506440

    Change-Id: I44a6cff2ccba1ba53a18da90c9d74cbb6084ca0c
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Nastya Urlapova (aurlapova) wrote :

Since change was merged and we did many SWARM runs, issue was moved to Fix Released.

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.