launching gnocchi failed with uncommentted default_aggregation_methods

[Lianhao Lu]

Using the gnocchi.conf generated by tox -e genconfig, and uncomment the following default_aggregation_methods options in the config file:

[archive_policy]

#
# From gnocchi
#

# Default aggregation methods to use in created archive policies
# (unknown type)
#default_aggregation_methods = ['mean', 'min', 'max', 'sum', 'std', 'median', 'count', '95pct']

now we can't launch gnocchi and get the following error output:
$ gnocchi-api --config-file etc/gnocchi/gnocchi.conf
2015-10-15 19:07:39.451 12006 CRITICAL gnocchi [-] ConfigFileValueError: Value for option default_aggregation_methods is not valid: Valid values are [31pct, 81pct, 13pct, 25pct, 40pct, 50pct, 6pct, 55pct, 11pct, 22pct, 73pct, 42pct, 76pct, 70pct, 84pct, 94pct, 20pct, 32pct, 60pct, 34pct, 66pct, 95pct, 33pct, 1pct, 85pct, 21pct, 82pct, 12pct, count, 63pct, 72pct, 10pct, 23pct, 35pct, 43pct, 83pct, 17pct, 37pct, 58pct, 88pct, 61pct, 67pct, 79pct, 87pct, 15pct, std, 99pct, 86pct, median, 64pct, 69pct, 78pct, 14pct, 56pct, 3pct, 5pct, mean, 57pct, 59pct, 65pct, 39pct, 16pct, 71pct, 36pct, 89pct, 93pct, 48pct, 28pct, 75pct, 98pct, 18pct, 52pct, 7pct, 9pct, min, sum, 92pct, 90pct, 45pct, 68pct, 38pct, 44pct, 2pct, 4pct, 54pct, 26pct, max, 49pct, 53pct, 29pct, 74pct, 80pct, 24pct, 51pct, 62pct, 97pct, 47pct, 77pct, 41pct, last, 46pct, 8pct, 96pct, 30pct, 91pct, 27pct, 19pct, first], but found "['mean', 'min', 'max', 'sum', 'std', 'median', 'count', '95pct']"
2015-10-15 19:07:39.451 12006 ERROR gnocchi Traceback (most recent call last):
2015-10-15 19:07:39.451 12006 ERROR gnocchi File "/usr/local/bin/gnocchi-api", line 10, in <module>
2015-10-15 19:07:39.451 12006 ERROR gnocchi sys.exit(api())
2015-10-15 19:07:39.451 12006 ERROR gnocchi File "/opt/stack/gnocchi/gnocchi/cli.py", line 43, in api
2015-10-15 19:07:39.451 12006 ERROR gnocchi app.build_server()
2015-10-15 19:07:39.451 12006 ERROR gnocchi File "/opt/stack/gnocchi/gnocchi/rest/app.py", line 147, in build_server
2015-10-15 19:07:39.451 12006 ERROR gnocchi conf = service.prepare_service()
2015-10-15 19:07:39.451 12006 ERROR gnocchi File "/opt/stack/gnocchi/gnocchi/service.py", line 62, in prepare_service
2015-10-15 19:07:39.451 12006 ERROR gnocchi conf.log_opt_values(LOG, logging.DEBUG)
2015-10-15 19:07:39.451 12006 ERROR gnocchi File "/usr/local/lib/python2.7/dist-packages/oslo_config/cfg.py", line 2233, in log_opt_values
2015-10-15 19:07:39.451 12006 ERROR gnocchi _sanitize(opt, getattr(group_attr, opt_name)))
2015-10-15 19:07:39.451 12006 ERROR gnocchi File "/usr/local/lib/python2.7/dist-packages/oslo_config/cfg.py", line 2559, in __getattr__
2015-10-15 19:07:39.451 12006 ERROR gnocchi return self._conf._get(name, self._group)
2015-10-15 19:07:39.451 12006 ERROR gnocchi File "/usr/local/lib/python2.7/dist-packages/oslo_config/cfg.py", line 2276, in _get
2015-10-15 19:07:39.451 12006 ERROR gnocchi value = self._do_get(name, group, namespace)
2015-10-15 19:07:39.451 12006 ERROR gnocchi File "/usr/local/lib/python2.7/dist-packages/oslo_config/cfg.py", line 2319, in _do_get
2015-10-15 19:07:39.451 12006 ERROR gnocchi % (opt.name, str(ve)))
2015-10-15 19:07:39.451 12006 ERROR gnocchi ConfigFileValueError: Value for option default_aggregation_methods is not valid: Valid values are [31pct, 81pct, 13pct, 25pct, 40pct, 50pct, 6pct, 55pct, 11pct, 22pct, 73pct, 42pct, 76pct, 70pct, 84pct, 94pct, 20pct, 32pct, 60pct, 34pct, 66pct, 95pct, 33pct, 1pct, 85pct, 21pct, 82pct, 12pct, count, 63pct, 72pct, 10pct, 23pct, 35pct, 43pct, 83pct, 17pct, 37pct, 58pct, 88pct, 61pct, 67pct, 79pct, 87pct, 15pct, std, 99pct, 86pct, median, 64pct, 69pct, 78pct, 14pct, 56pct, 3pct, 5pct, mean, 57pct, 59pct, 65pct, 39pct, 16pct, 71pct, 36pct, 89pct, 93pct, 48pct, 28pct, 75pct, 98pct, 18pct, 52pct, 7pct, 9pct, min, sum, 92pct, 90pct, 45pct, 68pct, 38pct, 44pct, 2pct, 4pct, 54pct, 26pct, max, 49pct, 53pct, 29pct, 74pct, 80pct, 24pct, 51pct, 62pct, 97pct, 47pct, 77pct, 41pct, last, 46pct, 8pct, 96pct, 30pct, 91pct, 27pct, 19pct, first], but found "['mean', 'min', 'max', 'sum', 'std', 'median', 'count', '95pct']"

It seems the default value put in the gnocchi.conf is in incorrect format.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/235269

[Julien Danjou (jdanjou)]

I *think* that this is a bug in the oslo.config generator that includes the quote when printing the strings.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235269
Committed: https://git.openstack.org/cgit/openstack/gnocchi/commit/?id=3488f47a71cf8fcefb55bde8029e20d5cd7c0604
Submitter: Jenkins
Branch: master

commit 3488f47a71cf8fcefb55bde8029e20d5cd7c0604
Author: Lianhao Lu <email address hidden>
Date: Thu Oct 15 19:23:23 2015 +0800

    Use ListOpt for default_aggregation_methods option

    Use the latest ListOpt from oslo.config 2.5.0 for
    default_aggregation_methods option so the generated sample config file
    will contain the correct default value format.

    Closes-Bug: #1506431
    Change-Id: I12b701ae42f49dbde5d8a5b639cb1a70859713d4

[ChangBo Guo(gcb) (glongwave)]

It seems using wrong type of config option