OVSDB client in ToR agent needs to assure route table sanity

[Prabhjot Singh Sethi]

OvsDB client in ToR agent needs to assure that while deleting of route table is in process it should not start creating new route table object in parallel to avoid possibility of duplicate rows for unicast remote route.

which can cause which to mis-behave

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14517
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/14517
Committed: http://github.org/Juniper/contrail-controller/commit/549cc205895d5c5e38b51e9507faa8f2788a3384
Submitter: Zuul
Branch: master

commit 549cc205895d5c5e38b51e9507faa8f2788a3384
Author: Prabhjot Singh Sethi <email address hidden>
Date: Mon Oct 19 09:29:43 2015 +0530

ToR Agent to assure OVSDB route table sanity

Issue:
------
while deleting and adding the route table under vrf,
ovsdb client may end up creating a new table before
the previous cleanup is complete, which can potentially
result in inconsitent state, in ovsdb-server and HA stale
exported routes

Fix:
----
force VRF to wait for Add/Delete ACK, triggered on route
table delete to assure, new route table is not created
before completion of cleanup

Closes-Bug: 1506325
Change-Id: I91f5aa2c425d263bb825119a39c1d35ceb83d014

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18386
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18389
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18390
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18386
Committed: http://github.org/Juniper/contrail-controller/commit/c70f2157c221a7f34eab04b6393fb61c608e52cb
Submitter: Zuul
Branch: R2.21.x

commit c70f2157c221a7f34eab04b6393fb61c608e52cb
Author: Prabhjot Singh Sethi <email address hidden>
Date: Mon Oct 19 09:29:43 2015 +0530

ToR Agent to assure OVSDB route table sanity

Issue:
------
while deleting and adding the route table under vrf,
ovsdb client may end up creating a new table before
the previous cleanup is complete, which can potentially
result in inconsitent state, in ovsdb-server and HA stale
exported routes

Fix:
----
force VRF to wait for Add/Delete ACK, triggered on route
table delete to assure, new route table is not created
before completion of cleanup

Closes-Bug: 1506325
(cherry picked from commit 549cc205895d5c5e38b51e9507faa8f2788a3384)

Conflicts:
 src/vnsw/agent/ovs_tor_agent/ovsdb_client/ha_stale_l2_route.cc
 src/vnsw/agent/ovs_tor_agent/ovsdb_client/ovsdb_object.cc

Change-Id: I91f5aa2c425d263bb825119a39c1d35ceb83d014

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18389
Committed: http://github.org/Juniper/contrail-controller/commit/125e4a6d0f191e8ad224acd157e5be5f55c1c789
Submitter: Zuul
Branch: R2.22.x

commit 125e4a6d0f191e8ad224acd157e5be5f55c1c789
Author: Prabhjot Singh Sethi <email address hidden>
Date: Mon Oct 19 09:29:43 2015 +0530

ToR Agent to assure OVSDB route table sanity

Issue:
------
while deleting and adding the route table under vrf,
ovsdb client may end up creating a new table before
the previous cleanup is complete, which can potentially
result in inconsitent state, in ovsdb-server and HA stale
exported routes

Fix:
----
force VRF to wait for Add/Delete ACK, triggered on route
table delete to assure, new route table is not created
before completion of cleanup

Closes-Bug: 1506325
(cherry picked from commit 549cc205895d5c5e38b51e9507faa8f2788a3384)

Conflicts:
 src/vnsw/agent/ovs_tor_agent/ovsdb_client/ha_stale_l2_route.cc
 src/vnsw/agent/ovs_tor_agent/ovsdb_client/ovsdb_object.cc

Change-Id: I91f5aa2c425d263bb825119a39c1d35ceb83d014
(cherry picked from commit c70f2157c221a7f34eab04b6393fb61c608e52cb)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18390
Committed: http://github.org/Juniper/contrail-controller/commit/782697b73ef405f49dee49a62b4fb0404c5e2b32
Submitter: Zuul
Branch: R2.20

commit 782697b73ef405f49dee49a62b4fb0404c5e2b32
Author: Prabhjot Singh Sethi <email address hidden>
Date: Mon Oct 19 09:29:43 2015 +0530

ToR Agent to assure OVSDB route table sanity

Issue:
------
while deleting and adding the route table under vrf,
ovsdb client may end up creating a new table before
the previous cleanup is complete, which can potentially
result in inconsitent state, in ovsdb-server and HA stale
exported routes

Fix:
----
force VRF to wait for Add/Delete ACK, triggered on route
table delete to assure, new route table is not created
before completion of cleanup

Closes-Bug: 1506325
(cherry picked from commit 549cc205895d5c5e38b51e9507faa8f2788a3384)

Conflicts:
 src/vnsw/agent/ovs_tor_agent/ovsdb_client/ha_stale_l2_route.cc
 src/vnsw/agent/ovs_tor_agent/ovsdb_client/ovsdb_object.cc

Change-Id: I91f5aa2c425d263bb825119a39c1d35ceb83d014
(cherry picked from commit c70f2157c221a7f34eab04b6393fb61c608e52cb)