type-list does not scale. Makes Horizon unusable for Manila.

[Mark Sturdevant]

manila type-list is taking over 1 minute to run. This makes the Horizon UI completely fail because it won't wait that long. It cannot even do "create share" because it needs a type list.

This performance problem was found on a system that had created 4000 shares, created an access rule for each one, and deleted the shares. Somehow with 4000 deleted shares, deleted share instances, deleted access rules, etc... the type-list query became slow. I'm not sure if it is doing an unnecessary join or if it just needs better indexes. It seems like maybe both.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/235364

[Valeriy Ponomaryov (vponomaryov)]

Please, see testing results before and after fix: https://goo.gl/lyfNaD

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235364
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=f1ada3fe97942931c181ffe95df6233e3f3c9277
Submitter: Jenkins
Branch: master

commit f1ada3fe97942931c181ffe95df6233e3f3c9277
Author: Valeriy Ponomaryov <email address hidden>
Date: Thu Oct 15 16:51:18 2015 +0300

    Fix share type model scalability for get request

    "share type list" operation greatly depends on amount of records in
    "shares" table. It leads to big slowness of just requesting list
    of several records of share types. That can take dozens of seconds.

    Main reason for it lays in usage of redundant "relationship" of "share
    types" table to "shares" table. It is not used in Manila, so remove it.

    Change-Id: I463b12e2eb7249b42835be063cd953b56ee7376d
    Closes-Bug: #1506240

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/236135

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/236135
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=f8d07309dd1cfe95030fc0bc8fa670354bf09b0a
Submitter: Jenkins
Branch: stable/liberty

commit f8d07309dd1cfe95030fc0bc8fa670354bf09b0a
Author: Valeriy Ponomaryov <email address hidden>
Date: Thu Oct 15 16:51:18 2015 +0300

    Fix share type model scalability for get request

    "share type list" operation greatly depends on amount of records in
    "shares" table. It leads to big slowness of just requesting list
    of several records of share types. That can take dozens of seconds.

    Main reason for it lays in usage of redundant "relationship" of "share
    types" table to "shares" table. It is not used in Manila, so remove it.

    Change-Id: I463b12e2eb7249b42835be063cd953b56ee7376d
    Closes-Bug: #1506240
    (cherry picked from commit f1ada3fe97942931c181ffe95df6233e3f3c9277)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/manila 2.0.0.0b1 development milestone.

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/manila 1.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 1.0.1 release.