Stack update leaves raw template behind

[Thomas Herve]

I noticed that a stack update creates 3 additional raw_template rows. Unfortunately, we seem to lose the reference to one template:

Before the update:

select raw_template_id, prev_raw_template_id from stack;
| 1 | NULL |

select id from raw_template;
| 1 |

After the stack update:

select raw_template_id, prev_raw_template_id from stack;

| 4 | 2 |
| 3 | NULL |

select id from raw_template;

| 1 |
| 2 |
| 3 |
| 4 |

When we flip from 1 to 4 in the stack, we don't delete the old template.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/234818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/234818
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=117e5a0e654111de3f28900228d858cd0683cb1f
Submitter: Jenkins
Branch: master

commit 117e5a0e654111de3f28900228d858cd0683cb1f
Author: Thomas Herve <email address hidden>
Date: Wed Oct 14 16:44:42 2015 +0200

    Delete previous template upon update

    During stack update, we flip the stack raw_template a number of times.
    In case of success, we leave the old active raw_template row unlinked to
    anything, so it needs to be deleted. This patch does so.

    Change-Id: I6f3ff5bfbac417e3bd6032cabfbc00bd6dec8b02
    Closes-Bug: #1506077

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/heat 6.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/333544

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/333544
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=c43ae9a7231b5911376d88f3385c8dbb4d869d3d
Submitter: Jenkins
Branch: stable/liberty

commit c43ae9a7231b5911376d88f3385c8dbb4d869d3d
Author: Thomas Herve <email address hidden>
Date: Wed Oct 14 16:44:42 2015 +0200

    Delete previous template upon update

    During stack update, we flip the stack raw_template a number of times.
    In case of success, we leave the old active raw_template row unlinked to
    anything, so it needs to be deleted. This patch does so.

    Change-Id: I6f3ff5bfbac417e3bd6032cabfbc00bd6dec8b02
    Closes-Bug: #1506077
    (cherry picked from commit 117e5a0e654111de3f28900228d858cd0683cb1f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 5.0.2 release.