doc8 build-depends on itself

Bug #1505941 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
doc8
Opinion
Undecided
Unassigned

Bug Description

In test-requirements.txt, I could read "doc8". A package should never build-depends on itself. Please get rid of this.

Revision history for this message
Ian Cordasco (icordasc) wrote :

It makes sense for a project that enforces standards to run the standards enforcement against itself. This is fairly common practice. pep8, pyflakes, mccabe, flake8, and pylint all do this.

Changed in doc8:
status: New → Opinion
Revision history for this message
Thomas Goirand (thomas-goirand) wrote :

Ian, could you *PLEASE* stop closing each and every bug that I open, setting them as invalid or incomplete? Maybe try to understand why I'm opening a bug, or ask first instead would be the correct course of action.

There is here absolutely zero reason for doc8 to requires: itself, it could use its own files to check itself rather than pulling from pip.

Revision history for this message
Ian Cordasco (icordasc) wrote :

Thomas, why do you continue to exaggerate. I have proposed fixes for several of your bugs and closed ... 2? 3?

There is nothing that requires you to install doc8 from pip. The dependencies are declarative and doc8 never specifies a version that it expects. This means that any version (including the same one that has been packaged) should work. Just because tox does one thing does not mean you have to do the same thing.

Revision history for this message
Thomas Goirand (thomas-goirand) wrote :

Ian, it'd be nice if you could as well stop personal comments in bug reports. I've asked you to stop closing bugs because that's not the first time. This is a fact, which you just recognize. No need to write that I *continue* to *exaggerate*. Please just focus on the technical bits of bug reports, which is the only important thing.

So, back to the issue. I probably failed to explain properly, because clearly, you didn't fully understood what I wrote (my communication teacher said many times that it is *always* the fault of the person who attempted to explain, and I've seen many times that he's right...).

There's no need for doc8 to require itself. It could use itself without requiring itself, as per definition, the sources are available locally when using tox. Installing doc8 from pip in a venv so that testing doc8 can use that version is also not a great idea, because by definition, the pip install version will not be as up-to-date as the git clone being tested.

Or did I miss something here? For what reason having doc8 in the venv is necessary, when doc8 could already use itself?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.