empty replica_set from config can clobber url-based replica set for mongodb

[Chris Dent]

In <Mitaka, In ceilometer.storage.mongo.utils the value of CONF.database.mongodb_replica_set will always be used when creating a connection to mongodb. In situations where replica_set is being provided by the database connection URL the defalut value of '' can override the URL and cause connection failures.

The likely solution is to guard the creation of the MongoClient to check for replica_set having a value and only passing the arg if so.

This problem is not present in Mitaka because in that version the mongodb_replica_set version is gone.

[Chris Dent (cdent)]

Because of the change in config handling between Mitaka and Liberty for replica_set, we can't simply backport from Mitaka.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/234254

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/234254
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=d91e1916c6c34892dd1026954bc7327ee4c1898e
Submitter: Jenkins
Branch: stable/liberty

commit d91e1916c6c34892dd1026954bc7327ee4c1898e
Author: Chris Dent <email address hidden>
Date: Tue Oct 13 14:27:09 2015 +0000

    If mongodb_replica_set is empty do not pass it to client

    Otherwise a replicaSet parameter in a db connection URL will be
    clobbered by the empty configuration setting.

    Note that this is a direct patch to stable/liberty, not a backport from
    master because master has changed such that there is no longer a
    mongodb_replica_set configuration setting.

    Change-Id: Ic8de93f58ff1cf21888719597490f987d703cab6
    Closes-Bug: #1505669

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/ceilometer 5.0.1 release.