lpstat plugin doesn't return job count

[Stevel]

Ubuntu release: 14.04.3 LTS
munin-plugins-core version: 2.0.19-3

The returned job count is always zero because a variable assignment is missing from the script.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "lpstat-return-number-of-jobs.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Stevel (stevel-launchpad)]

In addition it seems that the metrics should be GAUGE instead of COUNTER. New patch attached.

[Robie Basak (racb)]

Thank you for submitting this patch and helping to make Ubuntu better.

Does this bug affect munin upstream? If so it should be sent there. We can cherry-pick it in Wily and Trusty as needed after it is accepted. Otherwise users will only get a temporary fix that will regress as soon as they upgrade to a newer release.

[Robie Basak (racb)]

Looks like $n_jobs is set correctly upstream and in 2.0.25-1 in Wily, so this is fixed but could be cherry-picked to Trusty.

Upstream still outputs a COUNTER and not a GAUGE (from https://github.com/munin-monitoring/munin/blob/devel/plugins/node.d/lpstat). If you think it should be changed, then please file an issue with upstream (https://github.com/munin-monitoring/munin/issues). It is not appropriate for Ubuntu to do something different from upstream here.

You've described two separate issues here but this bug can track only one, so I'll track the $n_jobs issue. If you want you can file a separate bug here in Ubuntu for the COUNTER/GAUGE thing, but I will not consider it valid for Ubuntu unless upstream say it is valid so you should file a bug upstream if you want it fixed.

For the $n_jobs issue tracked here, it is fixed in Wily so I will create a task for Trusty and mark it Fix Released for the development release (Wily). If you want to see this fixed in Trusty, then please follow https://wiki.ubuntu.com/StableReleaseUpdates#Procedure. In particular I need a step-by-step test case for verification, and a commitment from you that you will be prepared to carry out the verification. If you can do that then we can get this fixed for you in Trusty. Thanks!

[Utkarsh Gupta (utkarsh)]

Hello, Trusty reached "End of Standard Support" a while ago and so I am marking this as "Won't Fix". Thank you.