Broken error message during subnet creation

[Kahou Lei]

Whenever user create a Neutron subnet and Neutron returns error, Horizon will display :

Error: Failed to create subnet "90.0.0.0/24" for network "None": <Neutron error message>

Notice that "None" is supposed to be a network name.

The root cause is due to horizon/horizon/openstack_dashboard/dashboards/project/networks/subnets/workflows.py never pass Network object in the _create_subnet method and that breaks the error message.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/238219

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/238219
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=13c9b30078bab0115b0b0bd4aef7a315473e3d5a
Submitter: Jenkins
Branch: master

commit 13c9b30078bab0115b0b0bd4aef7a315473e3d5a
Author: Akanksha <email address hidden>
Date: Thu Oct 22 00:56:00 2015 +0530

    Fixes Broken Error Message on Subnet Creation

    Wrong key used for getting the name and id of network in the case of
    it not being passed into the method call.
    This fixes the key used.

    Change-Id: I6757a946be4696027befbe98b490881e967e80eb
    Closes-Bug:1505414

[Lin Hua Cheng (lin-hua-cheng)]

re-opening bug, as the patch caused a regression and had to be reverted

https://review.openstack.org/#/c/243983/

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 9.0.0.0b1 development milestone.

[Ying Zuo (yingzuo)]

Doug Hellmann,
I am running the master branch horizon and this issue still exists. Maybe I am missing something here. Can you please provide a link to the fix? Thanks.

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/245355
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/317379

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/398647

[Ernest Millan (millan)]

Screenshot of fix:

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/317379
Reason: Due to inactivity

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/398647
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/398647
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3a3cb681c912863bca586f4354b9a0205f9b25f4
Submitter: Zuul
Branch: master

commit 3a3cb681c912863bca586f4354b9a0205f9b25f4
Author: Ernest Millan <email address hidden>
Date: Wed Nov 16 16:00:17 2016 -0800

    Ensures proper network name in subnet error message

    We need to pass network object to _create_subnet()
    to show proper network name in subnet error message.
    The network itself has been retrieved in the view code, so what
    we need to do is to make it available in the workflow code.
    This commit makes 'network' information available in the workflow
    context_seed dict and CreateSubnet handle() method can use it.

    Also removes the unnecessary network_get in the admin subnet create
    form. we can retrieve a network object from context_seed['network']
    as we do in the project side code now.

    Change-Id: Ib2162814cbc7263fc03a9da0319c0b2b38732cc5
    Closes-bug: #1505414
    Co-Authored-By: Akihiro Motoki <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 15.0.0.0b2 development milestone.