Inet6 masks are not initialized

Bug #1505350 reported by Nischal Sheth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.0
Fix Committed
High
Tapan Karwa
R2.20
Fix Committed
High
Tapan Karwa
R2.20.x
Fix Committed
High
Tapan Karwa
Trunk
Fix Committed
High
Tapan Karwa

Bug Description

The implementation of Inet6Prefix::IsMoreSpecific uses Inet6Masks.
However, Inet6Masks::Init is never called in the contrail-control
binary. It's only called explicitly from the Setup methods of inet6
tests.

Suggested fix is to use MODULE_INITIALIZER trick in inet6_route.cc
to ensure that Inet6Masks::Init is always called.

Nischal Sheth (nsheth)
description: updated
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/14373
Submitter: Tapan Karwa (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.0

Review in progress for https://review.opencontrail.org/14374
Submitter: Tapan Karwa (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/14375
Submitter: Tapan Karwa (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/14374
Committed: http://github.org/Juniper/contrail-controller/commit/fdd571c7b9e1db1730381b271d274e726a049090
Submitter: Zuul
Branch: R2.0

commit fdd571c7b9e1db1730381b271d274e726a049090
Author: Tapan Karwa <email address hidden>
Date: Mon Oct 12 14:22:54 2015 -0700

Call Inet6Masks::Init() via ModuleInitializer.

Inet6Masks::Init is never called in the contrail-control binary. It's only
called explicitly from the Setup methods of inet6 tests. But masks_ needs to be
initialized with all the 128 masks. Otherwise, certain introspect requests can
result in exceptions when Inet6Masks::PrefixlenToMask() tries to access the
empty vector.

Change-Id: Idc5639e8969453b475571d645ecf64287b00fadb
Closes-Bug: #1505350

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/14373
Committed: http://github.org/Juniper/contrail-controller/commit/129597e3a09229a48a6c9578a0a1bdf397d74962
Submitter: Zuul
Branch: R2.20

commit 129597e3a09229a48a6c9578a0a1bdf397d74962
Author: Tapan Karwa <email address hidden>
Date: Mon Oct 12 14:22:54 2015 -0700

Call Inet6Masks::Init() via ModuleInitializer.

Inet6Masks::Init is never called in the contrail-control binary. It's only
called explicitly from the Setup methods of inet6 tests. But masks_ needs to be
initialized with all the 128 masks. Otherwise, certain introspect requests can
result in exceptions when Inet6Masks::PrefixlenToMask() tries to access the
empty vector.

Change-Id: Idc5639e8969453b475571d645ecf64287b00fadb
Closes-Bug: #1505350

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/14375
Committed: http://github.org/Juniper/contrail-controller/commit/6c8b8db0b47a1f8c3533b177e9977c3ef41d0d21
Submitter: Zuul
Branch: master

commit 6c8b8db0b47a1f8c3533b177e9977c3ef41d0d21
Author: Tapan Karwa <email address hidden>
Date: Mon Oct 12 14:37:01 2015 -0700

Call Inet6Masks::Init() via ModuleInitializer.

Inet6Masks::Init is never called in the contrail-control binary. It's only
called explicitly from the Setup methods of inet6 tests. But masks_ needs to be
initialized with all the 128 masks. Otherwise, certain introspect requests can
result in exceptions when Inet6Masks::PrefixlenToMask() tries to access the
empty vector.

Change-Id: I4845f0946184c1a0dc347629134cc73da7ba3632
Closes-Bug: #1505350

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20.x

Review in progress for https://review.opencontrail.org/14396
Submitter: Tapan Karwa (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/14396
Committed: http://github.org/Juniper/contrail-controller/commit/e3c0dc34e17eef509d019c87bc907f08b92b63b9
Submitter: Zuul
Branch: R2.20.x

commit e3c0dc34e17eef509d019c87bc907f08b92b63b9
Author: Tapan Karwa <email address hidden>
Date: Mon Oct 12 14:22:54 2015 -0700

Call Inet6Masks::Init() via ModuleInitializer.

Inet6Masks::Init is never called in the contrail-control binary. It's only
called explicitly from the Setup methods of inet6 tests. But masks_ needs to be
initialized with all the 128 masks. Otherwise, certain introspect requests can
result in exceptions when Inet6Masks::PrefixlenToMask() tries to access the
empty vector.

Change-Id: Idc5639e8969453b475571d645ecf64287b00fadb
Closes-Bug: #1505350

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.