retype volume got error when max volume limit has arrived

[wanghao]

Create volumes until arriving max volume limit, and then retype one of volumes, cinder will raise error: "VolumelimitExceeded: Maximum number of volumes allowed exceeded for quota 'volumes'". The volume type limit is -1, so this should not get this error under retyping operation.

Test steps:
1. Set the volume limit of quota to 3.
2. Create 3 volumes successfully with volume_type A.
3. Retype one of volumes to volume_type B.
4. Cinder raise this error.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/233325

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233325
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=c68bc2eb2be41a437390cbd81a499bb0ea94f180
Submitter: Jenkins
Branch: master

commit c68bc2eb2be41a437390cbd81a499bb0ea94f180
Author: wanghao <email address hidden>
Date: Sat Oct 10 11:18:02 2015 +0800

    Retyping volume got error under max vol limit

    After reaching the max volume limit and
    retyping one of volumes, cinder will raise
    error: "VolumeLimitExceeded".

    This error shouldn't be occurring since the
    volume type limit is -1 and retyping doesn't
    change the volume quota, it changes the volume
    type quota.

    Change-Id: I5f25c47158ac24bef94078457a84248daa67e80f
    Closes-Bug: #1504719

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/cinder 8.0.0.0b2 development milestone.