PEP8 exclusions must be removed

Bug #1504352 reported by Roman Prykhodchenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Andrey Tykhonov

Bug Description

ATM H234,H302,H802 are excluded from PEP8 checker. Those exclusions must be eliminated in order to make the code correspond to the upstream standards.

Changed in fuel:
status: New → Confirmed
tags: added: tech-debt
tags: added: low-hanging-fruit
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Andrey Tykhonov (atykhonov)
status: Confirmed → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/237081

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-fuelclient (master)

Change abandoned by Andrey Tykhonov (<email address hidden>) on branch: master
Review: https://review.openstack.org/237081
Reason: We do the docstrings formatting for the --help option. But in the same time we need to have these docstrings PEP8 compliant. It seems it is contradictory requirements.

Revision history for this message
Andrey Tykhonov (atykhonov) wrote :

We do the docstrings formatting for the --help option. But in the same time we need to have these docstrings PEP8 compliant. It seems it is contradictory requirements.

Changed in fuel:
assignee: Andrey Tykhonov (atykhonov) → nobody
assignee: nobody → Fuel Python Team (fuel-python)
Changed in fuel:
status: In Progress → Incomplete
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Revision history for this message
Roman Prykhodchenko (romcheg) wrote :

@Andrey, I think we can remove the rest of exclusions and leave H405 for later.

description: updated
Changed in fuel:
status: Incomplete → Triaged
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Andrey Tykhonov (atykhonov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/250856

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
Andrey Tykhonov (atykhonov) wrote :

@Roman, ok, thank you! The patch is prepared for this change.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/250856
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=b77559b309a62650658424a43051cfeaba518748
Submitter: Jenkins
Branch: master

commit b77559b309a62650658424a43051cfeaba518748
Author: Andrey Tykhonov <email address hidden>
Date: Fri Nov 27 17:23:02 2015 +0200

    Remove PEP8 exclusions (H234, H302, H802)

    Remove PEP8 exclusions except H405. It must be removed when old CLI
    will be removed.

    Change-Id: If65189bb0f2b4d436adf2a312ce3e440a69773fb
    Closes-bug: #1504352

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.