environment's parameter_defaults not applied some parameter types
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Heat |
Fix Released
|
High
|
Jiří Stránský | ||
Kilo |
Fix Released
|
Undecided
|
Steven Hardy | ||
Liberty |
Fix Released
|
High
|
Unassigned |
Bug Description
Context:
* Current tripleo-
* Current python-
Goals:
Allow a user to pass more than one ntp server url in the command line.
Possible syntax :
* --ntp-server 0.test.
* --ntp-server 0.test.com --ntp-server 1.test.com (by adding action='append' to the param - https:/
In order to support such use cases NtpServer has been switched from string to comma_delimited
# Case 1
If I use directly --ntp-sever, for some reason the value is not passed to the Heat templates. NtpServer end up being empty
## Result 1
[stack@instack ~]$ openstack overcloud deploy --templates --ntp-server 0.test.
[...]
[stack@instack ~]$ heat stack-show overcloud | grep Ntp
| | "NtpServer": "",
# Case 2
If I use an Heat environment file, the NtpServer is filled acordingly.
## Result 2
[stack@instack ~]$ cat env.yaml
parameters:
NtpServer: 0.test.
[stack@instack ~]$ openstack overcloud deploy --templates -e env.yaml
[...]
heat stack-show overcloud | grep Ntp
| | "NtpServer": "0.test.
[1] https:/
[2] http://
Expected Results:
Whether using tripleoclient --ntp-server or directly the Heat environment, the value should be passed either way.
Changed in heat: | |
importance: | Undecided → High |
milestone: | none → mitaka-1 |
tags: | added: liberty-backport-potential tripleo |
Changed in heat: | |
assignee: | Jiří Stránský (jistr) → Steven Hardy (shardy) |
Changed in heat: | |
assignee: | Steven Hardy (shardy) → Jiří Stránský (jistr) |
tags: | removed: liberty-backport-potential |
no longer affects: | heat/juno |
Changed in heat: | |
status: | Fix Committed → Fix Released |
It is reproducible even with heatclient (with no tripleoclient involved). The parameter_defaults are passed from heatclient correctly though. This is a bug in Heat, it doesn't process environment's parameter_defaults correctly for any value of type comma_delimited _list. I hope i'll have a fix for this.