Add function for parsing metadata in shell.py

Bug #1503939 reported by Zhenyu Zheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Undecided
Zhenyu Zheng

Bug Description

Currently, the metadata is parsed using dict(v.split('=', 1) for v in args.meta)
and it has been used in several places through the code.

It could be better to have a common function for this to make it more readable
and easy to use in the future.

Changed in python-novaclient:
assignee: nobody → Zhenyu Zheng (zhengzhenyu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/232301

Changed in python-novaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/232301
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=09bb834b05106b36ff0ced47bfbd44ef915cbad6
Submitter: Jenkins
Branch: master

commit 09bb834b05106b36ff0ced47bfbd44ef915cbad6
Author: Kevin_Zheng <email address hidden>
Date: Thu Oct 8 09:38:34 2015 +0800

    Refactor parsing metadata to a common function

    Currently the metadata is parsed using
    dict(v.split('=', 1) for v in metadata)
    and was used in several places, it could
    be better if we refactor it to a common
    function. It will make it more readable
    and easier to use in the future.

    Change-Id: Ib0fcaacdbef65cdcb85ecc0c304f4933bef2627c
    Closes-Bug: #1503939

Changed in python-novaclient:
status: In Progress → Fix Committed
Changed in python-novaclient:
milestone: none → 2.35.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.