MuranoPlException: [yaql.language.exceptions.NoMatchingMethodException]: in engine logs after removing environment that was redeployed

[Anastasia Kuznetsova]

Steps to reproduce:
1. Create Murano environment
2. Add application to the env
3. Deploy it
4. After successful deployment, remove added component from env
5. Redeploy environment
6. Add two apps to the env
7. Redeploy environment
8. After successful redeploy, remove environment
9. Take a look at murano-engine log

Observed result:
Murano environment was successfully deleted, heat stack was deleted too.
But there is a huge TRACE in the murano-engine.log

http://paste.openstack.org/show/475621/

Expected result:
No traces in logs.

[Victor Ryzhenkin (vryzhenkin)]

Faced this one while testing new k8s api.
In case with k8s this bug cause environment hanging in 'DELETING' state.
All stacks were deleted, but environment - not.

Regarding this, raising importance to high.

[Victor Ryzhenkin (vryzhenkin)]

logs of deletion

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/233294

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/233295

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233295
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=0b4a06aee4151a8d1689ef4fa387c0b4aca65f26
Submitter: Jenkins
Branch: stable/liberty

commit 0b4a06aee4151a8d1689ef4fa387c0b4aca65f26
Author: Stan Lagun <email address hidden>
Date: Sat Oct 10 01:33:22 2015 +0300

    Do not try to delete server from deleted Heat stack

    Because now Environment's .destroy method would
    be called before that of an Instance the later will try
    to delete itself from the stack that is physically not
    existing and represented as an empty dictionary in
    HeatStack.current().

    With this change Instance will check stack existence
    before deleting anything.

    Also a method to check if Instance is present in Heat
    stack template was added so that application could check
    if it is safe to use the instance (for example to send Agent plans)

    Change-Id: I298f3f079a153ef87ed7213b7f1432c9e5e4b4b6
    Closes-Bug: #1503715

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233294
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=e6b7ccb8985e3da1f947deb9cc3618173f076d19
Submitter: Jenkins
Branch: master

commit e6b7ccb8985e3da1f947deb9cc3618173f076d19
Author: Stan Lagun <email address hidden>
Date: Sat Oct 10 01:33:22 2015 +0300

    Do not try to delete server from deleted Heat stack

    Because now Environment's .destroy method would
    be called before that of an Instance the later will try
    to delete itself from the stack that is physically not
    existing and represented as an empty dictionary in
    HeatStack.current().

    With this change Instance will check stack existence
    before deleting anything.

    Also a method to check if Instance is present in Heat
    stack template was added so that application could check
    if it is safe to use the instance (for example to send Agent plans)

    Change-Id: I298f3f079a153ef87ed7213b7f1432c9e5e4b4b6
    Closes-Bug: #1503715