Floating IP addresses sorting in Horizon doesn't work

Bug #1503685 reported by Fabrizio Soppelsa
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Released
Medium
Paul Karikh
6.1.x
Fix Released
High
Denis Puchkin
7.0.x
Fix Released
Medium
Denis Puchkin
8.0.x
Fix Released
Medium
Paul Karikh

Bug Description

Project -> Compute -> Access & Security -> Floating IPs sorting doesn't work

See also related bug: https://bugs.launchpad.net/horizon/+bug/1428172
The attached patch to that bug doesn't work in MOS.

Revision history for this message
Paul Karikh (pkarikh) wrote :

Also, here is the upstream bug: https://bugs.launchpad.net/horizon/+bug/1504136

Revision history for this message
Paul Karikh (pkarikh) wrote :

And MOS cherry-picked patch is here: https://review.fuel-infra.org/#/c/12830/

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/horizon (openstack-ci/fuel-8.0/liberty)

Reviewed: https://review.fuel-infra.org/12830
Submitter: mos-infra-ci <>
Branch: openstack-ci/fuel-8.0/liberty

Commit: e9c32ff271b727c174b79e9baa538c137f24e5fa
Author: Justin Pomeroy <email address hidden>
Date: Wed Oct 14 16:39:39 2015

Make IPv4 address sorting work on all tables

The current IPv4 address sorting will only work on tables such as
Instances where the IP address cell content is a list. This patch
makes the sorting also work on other tables such as Floating IPs
where the cell content is not a list.

Cherry-picked from https://review.openstack.org/#/c/233813/1

Closes-Bug: #1503685
Change-Id: I098cde44d03188925fa452ae83fe65a91897758b

Revision history for this message
Paul Karikh (pkarikh) wrote :

For the 7.0 fix should be the same.
For the 6.1
if (a.length === 1 && a[0] === '') {
    if (a === "") {
      a = s.split('.');
    }
}
condition should be added (since it is missing there) in the same place, where it is in 8.0 patch.

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/horizon (master)

Fix proposed to branch: master
Change author: Justin Pomeroy <email address hidden>
Review: https://review.fuel-infra.org/13178

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on openstack/horizon (master)

Change abandoned by Dmitry Sutyagin <email address hidden> on branch: master
Review: https://review.fuel-infra.org/13178
Reason: made by mistake

Revision history for this message
Roman Rufanov (rrufanov) wrote :

customer found in 6.1

tags: added: support
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/horizon (openstack-ci/fuel-7.0/2015.1.0)

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: Justin Pomeroy <email address hidden>
Review: https://review.fuel-infra.org/13727

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/horizon (openstack-ci/fuel-6.1/2014.2)

Fix proposed to branch: openstack-ci/fuel-6.1/2014.2
Change author: Denis Puchkin <email address hidden>
Review: https://review.fuel-infra.org/13806

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/horizon (openstack-ci/fuel-6.1/2014.2)

Reviewed: https://review.fuel-infra.org/13806
Submitter: Vitaly Sedelnik <email address hidden>
Branch: openstack-ci/fuel-6.1/2014.2

Commit: e1d6971c2c049a07b6e54723d0928df9e6b23b49
Author: Denis Puchkin <email address hidden>
Date: Wed Nov 11 10:25:30 2015

Make IPv4 address sorting work on all tables

The current IPv4 address sorting will only work on tables such as
Instances where the IP address cell content is a list. This patch
makes the sorting also work on other tables such as Floating IPs
where the cell content is not a list.

Closes-Bug: #1503685
Change-Id: I098cde44d03188925fa452ae83fe65a91897758b

tags: added: on-verification
Revision history for this message
Vadim Rovachev (vrovachev) wrote :

Verified on 6.1 on Ubuntu.
Packages:
python-django-horizon
Version:
2014.2.2-1~u14.04+mos33

tags: removed: on-verification
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/horizon (openstack-ci/fuel-7.0/2015.1.0)

Reviewed: https://review.fuel-infra.org/13727
Submitter: Vitaly Sedelnik <email address hidden>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: 65bfbb966ee69472e156d8505fe2f32fdb3b7a9c
Author: Justin Pomeroy <email address hidden>
Date: Tue Nov 10 12:53:36 2015

Make IPv4 address sorting work on all tables

The current IPv4 address sorting will only work on tables such as
Instances where the IP address cell content is a list. This patch
makes the sorting also work on other tables such as Floating IPs
where the cell content is not a list.

Cherry-picked from https://review.openstack.org/#/c/233813/1

Closes-Bug: #1503685
Change-Id: I098cde44d03188925fa452ae83fe65a91897758b

tags: added: on-verification
Revision history for this message
Alexey Stupnikov (astupnikov) wrote :

Verified on MOS 7.0, packages:
openstack-dashboard 2015.1.1-1~u14.04%2bmos4295
python-django-horizon 2015.1.1-1~u14.04%2bmos4295

tags: removed: on-verification
tags: added: rn7.0-mu2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.