[nailgun-agent] ignores network interfaces unless they named as eth$N

[Aleksey Zvyagintsev]

Ignores network interfaces unless they named as eth* [1]
VERSION:
  release: "7.0"
  openstack_version: "2015.1.0-7.0"
  build_number: "301"
  nailgun_sha: "4162b0c15adb425b37608c787944d1983f543aa8"
  python-fuelclient_sha: "486bde57cda1badb68f915f66c61b544108606f3"
  fuel-agent_sha: "50e90af6e3d560e9085ff71d2950cfbcca91af67"
  fuel-nailgun-agent_sha: "d7027952870a35db8dc52f185bb1158cdd3d1ebd"
  astute_sha: "6c5b73f93e24cc781c809db9159927655ced5012"
  fuel-library_sha: "5d50055aeca1dd0dc53b43825dc4c8f7780be9dd"
  fuel-ostf_sha: "2cd967dccd66cfc3a0abd6af9f31e5b4d150a11c"
  fuelmain_sha: "a65d453215edb0284a2e4761be7a156bb5627677"

Ethernet interfaces can have arbitrary names (for instance, enp2s0f0)
nailgun agent should use information about device type from sysfs instead of guessing it based on the interface name.

Up to date releases of Ubuntu and CentOS use the predictable network interfaces naming ( http://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames ) So it will be a huge blocker on running agent in custom systems.

[1]https://github.com/stackforge/fuel-nailgun-agent/blob/master/agent#L269-L276

[Mike Scherbakov (mihgen)]

This is valid ask, in my opinion, however Nailgun should be ready to process such names of interfaces.
As well as other parts, including l23network.

[Matthew Mosesohn (raytrac3r)]

This bug is targeted for nailgun-agent. Why is it in library?
l23network can already handle devices of any name.

[Vladimir Sharshov (vsharshov)]

Guys, i've checked node with non-standard name and it report correcly. In UI we can see such info:

    NAME eth2
    MAC 64:FA:FF:30:CF:4E
    STATE down
    CURRENT SPEED 1.0 Gbps
    MAX SPEED 1.0 Gbps
    DRIVER e1000
    BUS INFO 0000:00:05.0
    ORIG NAME rename4
    PXE False

ORIG NAME rename4 and NAME eth2 proof, that report works without any problem with different names. I've closed this bug as Invalid. Feel free to reopen it. Please provide examples of wrong reaction for dev-based networks names in such case.

[Vladimir Sharshov (vsharshov)]

Sorry, i was misleading by custom iso. I can confirm that we have such bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/243597

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/243597
Committed: https://git.openstack.org/cgit/openstack/fuel-nailgun-agent/commit/?id=3e9d17211d65c80bf97c8d83979979f6c7feb687
Submitter: Jenkins
Branch: master

commit 3e9d17211d65c80bf97c8d83979979f6c7feb687
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Tue Nov 10 16:40:54 2015 +0300

    New way to get list of all physical ethernet interfaces

    Changes:

    * support predictable network interfaces naming based [0]
    * better and more reliable way to detect non-virtual, not a wireless ethernet interfaces.
    * support old and new Ruby version (1.8.7+)

    [0] http://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames

    Co-Authored-By: Alexei Sheplyakov <email address hidden>

    Change-Id: Ia61b23beaef38d3d74bf195d58c1e30dac690b7f
    Closes-Bug: #1502198

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/322897

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/322897
Committed: https://git.openstack.org/cgit/openstack/fuel-nailgun-agent/commit/?id=71361290d2131359769fca3c20897a74ff7230ef
Submitter: Jenkins
Branch: stable/7.0

commit 71361290d2131359769fca3c20897a74ff7230ef
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Tue Nov 10 16:40:54 2015 +0300

    New way to get list of all physical ethernet interfaces

    Changes:

    * support predictable network interfaces naming based [0]
    * better and more reliable way to detect non-virtual, not a wireless ethernet interfaces.
    * support old and new Ruby version (1.8.7+)

    [0] http://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames

    Co-Authored-By: Alexei Sheplyakov <email address hidden>

    Change-Id: Ia61b23beaef38d3d74bf195d58c1e30dac690b7f
    Closes-Bug: #1502198
    (cherry picked from commit 3e9d17211d65c80bf97c8d83979979f6c7feb687)