l23network has a duplicate constant

Bug #1501984 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Low
Alex Schultz

Bug Description

The l23network has MAX_BR_NAME_LENGTH defined in k_mod.rb and l2_bridge.rb. The noop tests throw a warning about the duplication.

netconfig/netconfig.pp
  on Ubuntu platforms
    behaves like OS
      behaves like compile
/home/jenkins/workspace/fuellib_noop_tests/deployment/puppet/l23network/lib/puppet/type/l2_bridge.rb:8: warning: already initialized constant MAX_BR_NAME_LENGTH
/home/jenkins/workspace/fuellib_noop_tests/deployment/puppet/l23network/lib/puppet/type/k_mod.rb:7: warning: previous definition of MAX_BR_NAME_LENGTH was here
        should compile into a catalogue without dependency cycles
  on CentOS platforms
    behaves like OS
      behaves like compile
        should compile into a catalogue without dependency cycles

Tags: area-library
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/230246

Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Alex Schultz (alex-schultz)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/230246
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=a07e00f45ff6bd7d20dca0f9e4be4a70cc74c1af
Submitter: Jenkins
Branch: master

commit a07e00f45ff6bd7d20dca0f9e4be4a70cc74c1af
Author: Alex Schultz <email address hidden>
Date: Thu Oct 1 21:32:34 2015 -0500

    Remove duplicated constant MAX_BR_NAME_LENGTH

    This change removes the MAX_BR_NAME_LENGTH from k_mod as it is also
    defined and used in l2_bridge.

    Change-Id: I23c88ebd947db4480c6c9322bd1fafa14ca2c540
    Closes-Bug: #1501984

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Pyzhov (dpyzhov)
tags: added: area-library
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.