Refactor the code : vanilla hadoop2 plugin code uses if statements inefficiently

Bug #1501663 reported by venkatesh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
Low
venkatesh

Bug Description

In sahara/plugins/vanilla/hadoop2/config.py refactor the method def get_open_ports(node_group).
It is using multiple if statements

Changed in sahara:
assignee: nobody → venkatesh (p-venkatesh551)
Changed in sahara:
status: New → In Progress
Revision history for this message
Michael McCune (mimccune) wrote :

i'm ok with bugs for refactoring the code, but i think the title should be more specific. something along the lines of "vanilla hadoop2 plugin code uses if statements inefficiently", but "refactor the code" is not descriptive enough.

Changed in sahara:
importance: Undecided → Low
summary: - Refactor the code
+ Refactor the code : vanilla hadoop2 plugin code uses if statements
+ inefficiently
Revision history for this message
Michael McCune (mimccune) wrote :

thanks Venkatesh!

Changed in sahara:
milestone: none → mitaka-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/228205
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=e019d9cd7216fc88ac2ba91069902aa6fbda2e64
Submitter: Jenkins
Branch: master

commit e019d9cd7216fc88ac2ba91069902aa6fbda2e64
Author: Venkateswarlu Pallamala <email address hidden>
Date: Sat Sep 26 12:01:39 2015 -0700

    replace multiple if stmts with dict and for loop

    Partial-Bug: #1501663
    Change-Id: Ib62b8085dbd60767e35828cfcca4b6798b0cbfed

Changed in sahara:
status: In Progress → Fix Committed
Changed in sahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.