MAAS needs to reload page when region version changes
Bug #1501613 reported by
Mark Shuttleworth
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Blake Rouse | ||
Bug Description
If the webpage is left open and MAAS is upgraded in the background then the websocket will disconnect and reconnect. Once it reconnects it will receive newer data that is structured differently then its previous version. This is because the client has the cached JS from the old version of MAAS still running.
We need to catch this change in the websocket and when it occurs the entire page should be reloaded forcing the cache to be cleared as well.
Previous bug report description:
After upgrading to 1.9a2 and then visiting a node page I see a big change in the presentation of the nodes. Screenshot attached.
Related branches
lp:~blake-rouse/maas/reload-on-version-change
- Andres Rodriguez (community): Approve
-
Diff: 295 lines (+166/-4)8 files modifiedsrc/maasserver/context_processors.py (+1/-0)
src/maasserver/static/js/angular/directives/tests/test_version_reloader.js (+88/-0)
src/maasserver/static/js/angular/directives/version_reloader.js (+37/-0)
src/maasserver/static/js/angular/factories/general.js (+10/-0)
src/maasserver/static/js/angular/factories/tests/test_general.js (+16/-3)
src/maasserver/templates/maasserver/index.html (+1/-1)
src/maasserver/websockets/handlers/general.py (+6/-0)
src/maasserver/websockets/handlers/tests/test_general.py (+7/-0)
Revision history for this message
| Mark Shuttleworth (sabdfl) wrote | #1 |
| Changed in maas: | |
| milestone: | none → 1.9.0 |
| Changed in maas: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| summary: |
- Tag explosion on upgrade to 1.9a2 + MAAS needs to reload page when region version changes |
| description: | updated |
| Changed in maas: | |
| assignee: | nobody → Blake Rouse (blake-rouse) |
| tags: | added: ui websocket |
| Changed in maas: | |
| status: | Triaged → In Progress |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
