cluster health task fails because constraint is run before resource

[Alex Schultz]

Problem:
As seen in the CI[0], the cluster/health task sometimes fails because it attempts to create the constraint before the resource has been created. We need to fix the ordering to ensure that the resource gets created first.

Expected Result:
cluster/health task should work on the first try.

Actual Result:
cluster/health task fails with:

  node-1 2015-09-30T15:38:17.714212 err: (/Stage[main]/Cluster::Sysinfo/Cs_location[clone_sysinfo-on-node-1.test.domain.local]) Could not evaluate: Execution of '/usr/sbin/crm configure load update /tmp/puppet_crm_update20150930-20025-7vvw6q' returned 1: ERROR: constraint clone_sysinfo-on-node-1.test.domain.local references a resource clone_sysinfo which doesn't exist

[0] https://ci.fuel-infra.org/job/fuellib_review_pkgs_master_node/4730/artifact/logs/4730/fail_error_deploy_neutron_tun-fuel-snapshot-2015-09-30_15-40-58.tar.xz.filtered.log

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229508

[Anastasia Palkina (apalkina)]

Reproduced on ISO #108 for 8.0

1. Create new environment
2. Choose Neutron, tunnelling segmentation
3. Choose Ceilometer
4. Add 1 controller, 1 compute, 1 cinder, 2 mongo
5. Move Storage network to eth1
6. Move Management network to eth2 and untag it
7. Deploy the environment. It was successful
8. Start OSTF tests. It was successful
9. But there is error on controller (node-1) in puppet.log:

2015-10-05 13:59:44 ERR (/Stage[main]/Cluster::Sysinfo/Cs_location[clone_sysinfo-on-node-1.domain.tld]) Could not evaluate: Execution of '/usr/sbin/crm configure load update /tmp/puppet_crm_update20151005-17796-1o49w8a' returned 1: ERROR: constraint clone_sysinfo-on-node-1.domain.tld references a resource clone_sysinfo which doesn't exist

"build_id": "108", "openstack_version": "2015.1.0-8.0", "build_number": "108", "release_versions": {"2015.1.0-8.0": {"VERSION": {"build_id": "108", "openstack_version": "2015.1.0-8.0", "build_number": "108", "api": "1.0", "fuel-library_sha": "acfcfd289ca454585687b6ff9651b53e4ffaf0cd", "feature_groups": ["mirantis"], "fuel-nailgun-agent_sha": "d66f188a1832a9c23b04884a14ef00fc5605ec6d", "fuel-nailgun_sha": "ec56b54491ecb0182f66e675f549825abc1a96ee", "fuel-agent_sha": "e881f0dabd09af4be4f3e22768b02fe76278e20e", "production": "docker", "python-fuelclient_sha": "286939d3be220828f52e73b65928ed39662e1853", "astute_sha": "0f753467a3f16e4d46e7e9f1979905fb178e4d5b", "fuel-ostf_sha": "37c5d6113408a29cabe0f416fe99cf20e2bca318", "release": "8.0", "fuelmain_sha": "8e5e75302b2534fd38e4b41b795957111ac75543"}}}, "auth_required": true, "api": "1.0", "fuel-library_sha": "acfcfd289ca454585687b6ff9651b53e4ffaf0cd", "feature_groups": ["mirantis"], "fuel-nailgun-agent_sha": "d66f188a1832a9c23b04884a14ef00fc5605ec6d", "fuel-nailgun_sha": "ec56b54491ecb0182f66e675f549825abc1a96ee", "fuel-agent_sha": "e881f0dabd09af4be4f3e22768b02fe76278e20e", "production": "docker", "python-fuelclient_sha": "286939d3be220828f52e73b65928ed39662e1853", "astute_sha": "0f753467a3f16e4d46e7e9f1979905fb178e4d5b", "fuel-ostf_sha": "37c5d6113408a29cabe0f416fe99cf20e2bca318", "release": "8.0", "fuelmain_sha": "8e5e75302b2534fd38e4b41b795957111ac75543"

[Alex Schultz (alex-schultz)]

This does not affect <=7.0 as this is a bug on a feature added to 8.0.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229508
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=dd5ac7145fcfe3185aa475acc07635361ae738a2
Submitter: Jenkins
Branch: master

commit dd5ac7145fcfe3185aa475acc07635361ae738a2
Author: Alex Schultz <email address hidden>
Date: Wed Sep 30 11:18:51 2015 -0500

    Fix sysinfo resource declaration

    This change replaces the use of clone resources as each node may have a
    different disk layout. Additionally this change replaces cs_location
    with cs_rsc_location which has a proper autorequire for the cs_resource
    being defined.

    Change-Id: Ifa8a6932c0f0ba2bc05bc0ea9278cbfbe5ae8bb9
    Closes-Bug: #1501410
    Closes-Bug: #1504085

[Dmitriy Kruglov (dkruglov)]

Verified on MOS 8.0, build 303, using the initial scenario. The 2nd scenario about env with mongos (https://bugs.launchpad.net/fuel/+bug/1501410/comments/2) is blocked by the issue https://bugs.launchpad.net/fuel/+bug/1513736.

ISO info:
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "303"
  build_id: "303"
  fuel-nailgun_sha: "352548386007399a95a6f21b1fcd9c48a0726325"
  python-fuelclient_sha: "b2bbcdf1c0f38adb34cff01cb6040006911f2ea5"
  fuel-agent_sha: "49bb78675b749d15ae8f0f045dc2b0811777a9d6"
  fuel-nailgun-agent_sha: "a33a58d378c117c0f509b0e7badc6f0910364154"
  astute_sha: "c56dfde2da034151a7e707b381c4cf9d213b4ba2"
  fuel-library_sha: "14576a3dbb3be5e4013c306776dc2eaefe0c15e0"
  fuel-ostf_sha: "9910a4726cbd038c257582b429527e40c4c3cb20"
  fuel-mirror_sha: "dbbe9ddc2c8a336aa7ab62952761bd079e374d1d"
  fuelmenu_sha: "680b720291ff577f4c058cee25f85e563c96312e"
  shotgun_sha: "cacb93cbc28910ff0dc38f30a855efa9af50d8ce"
  network-checker_sha: "d443ef47abeda58d319bc8d33d5005dd09440a02"
  fuel-upgrade_sha: "1e894e26d4e1423a9b0d66abd6a79505f4175ff6"
  fuelmain_sha: "74e9affd54e5a31fd55ed75a3402940dd186a621"