dockerctl config contains old version number

Bug #1501368 reported by Vasiliy Pleshakov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Low
Matthew Mosesohn

Bug Description

Dockerctl config file contains use old version Fuel if /etc/fuel/version.xml is missing:
https://github.com/stackforge/fuel-library/blob/master/files/fuel-docker-utils/dockerctl_config#L17

Changed in fuel:
assignee: nobody → Fuel Library Team (fuel-library)
importance: Undecided → Low
milestone: none → 8.0
Revision history for this message
Matthew Mosesohn (raytrac3r) wrote :

We should fix this in the spec by setting _VERSION_ in the source file and then when we write the RPM, we should add fuel_release (like in fuel-main spec) and do a string substitution in %prep section

tags: added: low-hanging-fruit module-fuelmenu
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Kyrylo Galanov (kgalanov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/229877

Changed in fuel:
status: New → In Progress
Changed in fuel:
assignee: Kyrylo Galanov (kgalanov) → Matthew Mosesohn (raytrac3r)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/229877
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=570759c6634e5e68335634c9b001e8ac82887aea
Submitter: Jenkins
Branch: master

commit 570759c6634e5e68335634c9b001e8ac82887aea
Author: Kyrylo Galanov <email address hidden>
Date: Thu Oct 1 16:21:43 2015 +0300

    Remove hardcoded version from dockerctl config

    * Fuel version number fallback should be determined by RPM spec,
      not hardcoded in config
    * Fix dockerctl config template to use fact fuel_version
    * Add %check section to ensure sed works and strips out
      placeholder version string

    Change-Id: I28032852517ec8f7e959ad48a04621ec3e33fea1
    Closes-bug: #1501368

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Pyzhov (dpyzhov)
tags: added: area-library
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-library (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/239399

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/239445

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (master)

Change abandoned by Matthew Mosesohn (<email address hidden>) on branch: master
Review: https://review.openstack.org/239399
Reason: merged with https://review.openstack.org/#/c/239445

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/239445
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=247d5d81e371b8da97916cc6d69ad58db7ee8b2c
Submitter: Jenkins
Branch: master

commit 247d5d81e371b8da97916cc6d69ad58db7ee8b2c
Author: Matthew Mosesohn <email address hidden>
Date: Mon Oct 26 17:17:25 2015 +0300

    Fix version override of Fuel release in dockerctl

    Corrects options handling did not handle override
    of version so that one can correctly use the
    following commands:
    dockerctl -V 8.0 start postgres
    dockerctl --version 7.0 destroy nginx

    The wrong variable was in the template leaving the
    version defaulted to "", and then reverting to 8.0
    as hardocded by the RPM. Switched to @release var
    name.

    Fixed varname for dockerctl config in hardcoded conf
    distributed in the RPM so it does not get replaced.

    Change-Id: Ia864b0a9843f927aa85945e5ab0b2da4bec3a440
    Related-Commit: I28032852517ec8f7e959ad48a04621ec3e33fea1
    Related-Bug: #1501368
    Closes-Bug: #1510080

Changed in fuel:
status: Fix Committed → Fix Released
Revision history for this message
Veronica Krayneva (vkrayneva) wrote :

Verified on #513 iso

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.