Remove --tls flag from docker-swarm

[Adrian Otto]

The following code appears in magnum/templates/docker-swarm/fragments/write-docker-service.sh:

cat >> /etc/systemd/system/docker.service << END_TLS
          --tls \\
          --tlsverify \\
          --tlscacert="/etc/docker/ca.crt" \\
          --tlskey="/etc/docker/server.key" \\
          --tlscert="/etc/docker/server.crt" \\
END_TLS

The line --tls should be dropped, as this allows anonymous TLS connections to the server. This should also be fixed in:

magnum/templates/docker-swarm/fragments/write-swarm-master-service.sh

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229116

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229116
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=dc7560362e206b059f6a6c874053957e12fecb2b
Submitter: Jenkins
Branch: master

commit dc7560362e206b059f6a6c874053957e12fecb2b
Author: Daneyon Hansen <email address hidden>
Date: Tue Sep 29 19:15:14 2015 +0000

    Removes --tls flag from docker and swarm-manager daemons

    Previously, the --tls flag was being used along with other tls
    related flags to secure the docker daemon. The --tls flag should
    not be used to perform mutual authentication between the docker
    daemon and client. This patch removes the use of --tls throughout
    the code base.

    Closes-Bug: #1500982

    Change-Id: I1def8e7a2725c0cdbb8862c6a8199b17e8ae841e