Dell SC: cgsnapshot-delete doesn't actually delete

Bug #1500583 reported by Tom Swanson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Tom Swanson

Bug Description

The Dell StorageCenter driver fails to locate the cgsnapshot and hence fails to delete it on a cgsnapshot-delete call. It considers this a success since the user could have done the deletion on the device.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/229007

Changed in cinder:
assignee: nobody → Tom Swanson (tom-swanson)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/229007
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e529e4d6cc71003c53126612dd869fa6fb23493a
Submitter: Jenkins
Branch: master

commit e529e4d6cc71003c53126612dd869fa6fb23493a
Author: Tom Swanson <email address hidden>
Date: Tue Sep 29 10:26:48 2015 -0500

    Dell SC: cgsnapshot-delete doesn't actually delete

    dell_storagecenter_api.py was looking for the cgsnapshot for
    cgsnapshot-delete via the wrong REST API call. It was also only
    looking for the first volume's snapshot rather than all snapshots
    associated with a cgsnapshot. It now locates the snapshots properly
    and expires the associated replays on cgsnapshot-delete.

    Tests updated appropriately.

    Change-Id: I1e635db8b06d3d7a78573e6e8a2a4c25b7fb458d
    Closes-Bug: #1500583

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/229654

Changed in cinder:
milestone: none → liberty-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/liberty)

Reviewed: https://review.openstack.org/229654
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f9e6c5f88c96bcbd181e991219d4ecbf9b8cf833
Submitter: Jenkins
Branch: stable/liberty

commit f9e6c5f88c96bcbd181e991219d4ecbf9b8cf833
Author: Tom Swanson <email address hidden>
Date: Tue Sep 29 10:26:48 2015 -0500

    Dell SC: cgsnapshot-delete doesn't actually delete

    dell_storagecenter_api.py was looking for the cgsnapshot for
    cgsnapshot-delete via the wrong REST API call. It was also only
    looking for the first volume's snapshot rather than all snapshots
    associated with a cgsnapshot. It now locates the snapshots properly
    and expires the associated replays on cgsnapshot-delete.

    Tests updated appropriately.

    Change-Id: I1e635db8b06d3d7a78573e6e8a2a4c25b7fb458d
    Closes-Bug: #1500583
    (cherry picked from commit e529e4d6cc71003c53126612dd869fa6fb23493a)

tags: added: in-stable-liberty
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-rc2 → 7.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235282

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)
Download full text (7.3 KiB)

Reviewed: https://review.openstack.org/235282
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0f7d289a2899082802499a498cba34a3abca321d
Submitter: Jenkins
Branch: master

commit 61026d4e4f2a58dd84ffb2e4e40ab99860b9316a
Author: Davanum Srinivas <email address hidden>
Date: Tue Oct 6 18:45:12 2015 -0700

    Squashed commit of WebOb 1.5 and oslo.db fixes

    Add testresources and testscenarios used by oslo.db fixture

    If we use oslo.db fixtures, we'll need these 2 packages or
    the next version of oslo.db release will break us.

    Closes-Bug: #1503501
    Change-Id: I8facdaf69c79b1b1ae4f9f64e9856e12f14440ed
    (cherry picked from commit ec40c3b6ddbfa4912ca6e612558efaef6043f3ae)

    Fix test_misc for WebOb 1.5

    WebOb 1.5 was released at 2015-10-11. With this new version,
    webob.exc.WSGIHTTPException() constructor now fails with a KeyError
    when the HTTP status code is 0.

    test_exceptions_raise() of test_misc tries to instanciate all
    exceptions of cinder.exception. The problem is that
    ConvertedException uses a default HTTP status code of 0.

    Modify the default HTTP status code of ConvertedException to 400 to
    fix the unit test. The bug is only in the test,
    cinder/api/openstack/wsgi.py copies an existing HTTP code:

        Fault(exception.ConvertedException(code=ex_value.code, ...)

    Closes-Bug: #1505153
    Change-Id: I1aec8038774828d48da4b0e831b390e33243809a
    (cherry picked from commit 867fccf833ffc597aa986cb6ff1b3b5c1101b9ba)

    Change default Exception code to 500

    As a part of the fix for LP#1505153, the invalid
    response of 0 was changed to 400 to fix a running
    issue with the new version of WebOb.

    It was pointed out after the fact however that a
    500 might be more appropriate here.

    Additionally, other projects have implemented a 500
    as the default so for the sake of consistency we should
    consider doing the same.

    This patch just changes the 400 to a 500 as the default
    code.

    Conflicts:
            cinder/tests/unit/test_exception.py

    NOTE(mriedem): The conflict is due to 17802086f not being
    in stable/liberty.

    Change-Id: Ie486dc49c927f9b50f07c1fc562e89c090924a40
    Closes-Bug: #1505488
    (cherry picked from commit 9a7cbe540c94d54194194f4747a52b8211f6372e)

commit 5268a8d61beee1b18d14fd3738e763a0a61b00f1
Author: Xing Yang <email address hidden>
Date: Wed Sep 23 11:22:43 2015 -0400

    Fix VMAX live migration problem

    Live migration fails for VMAX because the host is not taken into
    account when determining whether a volume is masked or not. For
    live migration it is necessary to know which host a volume is masked
    to. This patch fixes the problem by checking which host the volume
    is masked to.

    Change-Id: I693e29f7b26145bd1fd357b7d98377e26bfdfed8
    Closes-Bug: #1498964
    (cherry picked from commit 794e27c78255c94084b54821d44a36fd8f2096d7)

commit 2c09897f569a786998fd1ab50e42d81e9a2093a0
Author: OpenStack Proposal Bot <email address hidden>
Date: Sat Oct 3 06:22:46 2015 +0000

    Imported Tr...

Read more...

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/cinder 8.0.0.0b1

This issue was fixed in the openstack/cinder 8.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.