Murano

Regexp expression to validate keyword arguments is incorrect

Bug #1500233 reported by Stan Lagun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Stan Lagun
Murano mitaka-1 "m1"
Liberty
Fix Released
High
Serg Melikyan
Murano 1.0.1
Mitaka
Fix Released
High
Stan Lagun
Murano mitaka-1 "m1"

Bug Description

There are cases when property values may be provided in Murano in a form of a dictionary. For example new() function accepts
dictionary with property values. Murano filters this dictionary so that only the keys which names are valid yaql identifiers will
remain. This ensures that one cannot set special values (starting with '?', for example). However regexp that is used to validate
the name do not has ^/$ chars. As a result it is validated that the string contains valid identifier rather than it is so

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/228260

Changed in murano:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/228387

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/228260
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=f50c5407363f458f76ef21a150ef4217aad27822
Submitter: Jenkins
Branch: master

commit f50c5407363f458f76ef21a150ef4217aad27822
Author: Stan Lagun <email address hidden>
Date: Sun Sep 27 19:41:02 2015 +0300

    Keyword validation regexp was fixed

    There are several places where Murano validates a string
    to be valid yaql identifier (keyword). However the validation
    regexp used to validate that the string contained such identifier
    rather than be it

    Change-Id: I8f3ec08330e825ea3ed756c5d432234d251d8fc0
    Closes-Bug: #1500233

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/liberty)

Reviewed: https://review.openstack.org/228387
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=9eca4153710306e9b3f1ef2084914089762e8e96
Submitter: Jenkins
Branch: stable/liberty

commit 9eca4153710306e9b3f1ef2084914089762e8e96
Author: Stan Lagun <email address hidden>
Date: Sun Sep 27 19:41:02 2015 +0300

    Keyword validation regexp was fixed

    There are several places where Murano validates a string
    to be valid yaql identifier (keyword). However the validation
    regexp used to validate that the string contained such identifier
    rather than be it

    Change-Id: I8f3ec08330e825ea3ed756c5d432234d251d8fc0
    Closes-Bug: #1500233

Serg Melikyan (smelikyan)
Changed in murano:
milestone: liberty-rc2 → 1.0.0
Kirill Zaitsev (kzaitsev)
Changed in murano:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.