Add a CI check for hiera_array in puppet

[Matthew Mosesohn]

We had several commits in the 7.0 cycle that tried to introduce hiera_array lookups, causing strange results when working with plugins that override service role lists. At the current moment, no services require a hiera_array merge, but several arrays in hiera are sensitive to calls with hiera_array. The current list is:
corosync_roles
memcache_roles
mongo_roles
heat_roles
sahara_roles

We should add a voting CI job to watch for undesirable calls to hiera_array('KEY') in fuel-library

[Aleksandra Fedorova (bookwar)]

Please provide initial implementation for the test and how it might look on CI.

Ideally - just send a patch to the repository, similar to https://review.fuel-infra.org/#/c/5540/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/240844

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/240844
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=b5abd8e46733d434160a679b3a9a3b75c99fb8c2
Submitter: Jenkins
Branch: master

commit b5abd8e46733d434160a679b3a9a3b75c99fb8c2
Author: Bartłomiej Piotrowski <email address hidden>
Date: Mon Nov 2 13:48:56 2015 +0100

    Check osnailyfacter against undesired hiera_array calls

    Closes-bug: 1499803
    Change-Id: I1dfb317edeb5e2efd9fa075d73d9fa10fb64fc06

[Mikhail Samoylov (msamoylov)]

Bug was verificated.
Test scenario.
1. Create a test Puppet manifest:
cat osnailyfacter/manifests/test_for_bug_1499803.pp
class osnailyfacter::bug_1499803 {
  $test = hiera_array('test_roles')
}
2. Create test branch for bug
3. Git review https://review.openstack.org/#/c/245145/
4. Test failed with voiting (screen in attachement)