log rotate template overwrites on converged deployment

[Kevin Carter]

The log rotate template file from the rsyslog client role uses the same name for every execution dropping the os_aggregate_storage template. this causes issues for deployments that may have multiple services on the same hosts, typically when the "is_metal" flag is used.

To fix this issue the on disk name should have a default variable and all services consuming the role should set the variable accordingly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: kilo
Review: https://review.openstack.org/229463

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/227957
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=2346e5ced407e579fdfe4207500cffe4a69504e3
Submitter: Jenkins
Branch: master

commit 2346e5ced407e579fdfe4207500cffe4a69504e3
Author: Kevin Carter <email address hidden>
Date: Fri Sep 25 11:56:32 2015 -0500

    Fixes log rotate issue

    This change implements a change in the file name for each service
    so that the log rotate files don't collide when running on a shared
    host.

    Change-Id: Ia42656e4568c43667d610aa8421d2fa25437e2aa
    Closes-Bug: 1499799

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229463
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=f797b1ef28e2bed7d26b50fad42896d449518c15
Submitter: Jenkins
Branch: kilo

commit f797b1ef28e2bed7d26b50fad42896d449518c15
Author: Kevin Carter <email address hidden>
Date: Fri Sep 25 11:56:32 2015 -0500

    Fixes log rotate issue

    This change implements a change in the file name for each service
    so that the log rotate files don't collide when running on a shared
    host.

    Change-Id: Ia42656e4568c43667d610aa8421d2fa25437e2aa
    Closes-Bug: 1499799
    (cherry picked from commit 2346e5ced407e579fdfe4207500cffe4a69504e3)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 11.2.11 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 11.2.12 release.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.