juju-core

Windows ftb after version.Binary.OS change

Bug #1499689 reported by Martin Packman
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
Critical
Dave Cheney
juju-core 1.26-alpha1

Bug Description

Juju currently fails to build on windows after changes to the version package.

<http://juju-ci.vapour.ws/job/build-win-agent/911/>

# github.com/juju/juju/worker/diskmanager
.../src/github.com/juju/juju/worker/diskmanager/diskmanager_unsupported.go:25: version.Current.OS undefined (type version.Binary has no field or method OS)

Looks to be caused by 8dcb2950d1edca06310234f8edf313f5f5c5dd0a from pr #3210.

Martin Packman (gz)
tags: added: ci
Revision history for this message
Dave Cheney (dave-cheney) wrote :

I've reverted the commit.

Changed in juju-core:
status: Triaged → In Progress
assignee: nobody → Dave Cheney (dave-cheney)
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: none → 1.26-alpha1
Revision history for this message
Martin Packman (gz) wrote :

Thanks, CI confirmed the backout worked, also fixed a number of windows test failures, leaving bug 1499613 which is a seperate regression from another landing.

Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.