nailgun-agent reports wrong _master_ip_and_mac on multirack envs

[Aleksandr Didenko]

When we use multi L3 topology then we have several admin networks (one for each nodegroup). For example:

default nodegroup: 10.145.0.0/24
rack1 nodegroup: 10.144.0.0/24
rack2 nodegroup: 10.146.0.0/24

So during deployment (after network configuration) nodes will have several interfaces configured with different IPs on them (mgmt, admin, storage, private). And the following condition will work only for nodes from default nodegroup:
https://github.com/stackforge/fuel-nailgun-agent/blob/stable/7.0/agent#L634

Because only nodes from default nodegroup have admin IPs from the same network as fuel master node IP.

Thus nailgun-agent will report random IP/mac, because _master_ip_and_mac will return random IP/mac. Like this (see node-5 IP):
http://paste.openstack.org/show/473786/

We need to refactor _master_ip_and_mac method - nailgin-agent should get all the available admin networks from Fuel master node (as separate method, I guess) and check if intinfo[:addresses] matches any of those networks. If it matches, then it's master IP and mac.

How to reproduce:
1) deploy multirack env with 2+ nodegroups without L3 connectivity between their networks and with different admin network CIDR
2) check 'fuel node' list on fuel node

Expected result:
all nodes should have IPs from admin networks

Actual result:
nodes from non-default nodegroup have IPs not from admin network

Found on 6.1, but it should also affect 7.0 and master (8.0).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/227052

[Aleksandr Didenko (adidenko)]

If controllers are not in default nodegroup, then this bug also breaks OSTF.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/227052
Committed: https://git.openstack.org/cgit/openstack/fuel-nailgun-agent/commit/?id=2ad43a6ab17197c89b1854fa7f79eec7523fa91d
Submitter: Jenkins
Branch: master

commit 2ad43a6ab17197c89b1854fa7f79eec7523fa91d
Author: Nikita Koshikov <email address hidden>
Date: Wed Sep 23 18:30:34 2015 -0500

    Search IP--mac pair for mutli-rack deployments

    This search need, because in multi-rack deployments there are no
    local IP addresses in the master node APIs subnet.

    Co-Authored-By: Sergey Vasilenko <email address hidden>
    Change-Id: I33c47273e8b6cb047eddb248e61e3848b6112ffa
    Closes-bug: #1499007

[Artem Panchenko (apanchenko-8)]

verified

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "506"
  build_id: "506"
  fuel-nailgun_sha: "8e954abd70ef0083109f34289de2553dcda544d4"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "ec7e212972ead554f21b52b9e165156665f659df"
  fuel-ostf_sha: "ab5fd151fc6c1aa0b35bc2023631b1f4836ecd61"
  fuel-mirror_sha: "351d568fa3b3e4dd062054b91d766aa54d379867"
  fuelmenu_sha: "234cb4cbb30fbd2df00f388c28f31606d9cae15f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "94507c5e4dad6d8cfbd8f5d41aa8389d5335990a"