Convergence: test_stack_update_replace_with_ip_rollback failure

[Steve Baker]

2015-09-22 15:32:21.196 | 2015-09-22 15:32:21.198 | Captured traceback:
2015-09-22 15:32:21.199 | 2015-09-22 15:32:21.201 | ~~~~~~~~~~~~~~~~~~~
2015-09-22 15:32:21.201 | 2015-09-22 15:32:21.204 | Traceback (most recent call last):
2015-09-22 15:32:21.203 | 2015-09-22 15:32:21.205 | File "heat_integrationtests/functional/test_create_update_neutron_port.py", line 121, in test_stack_update_replace_with_ip_rollback
2015-09-22 15:32:21.204 | 2015-09-22 15:32:21.206 | self.assertEqual(_ip, new_ip)
2015-09-22 15:32:21.205 | 2015-09-22 15:32:21.208 | File "/opt/stack/new/heat/.tox/integration/local/lib/python2.7/site-packages/testtools/testcase.py", line 350, in assertEqual
2015-09-22 15:32:21.207 | 2015-09-22 15:32:21.210 | self.assertThat(observed, matcher, message)
2015-09-22 15:32:21.209 | 2015-09-22 15:32:21.211 | File "/opt/stack/new/heat/.tox/integration/local/lib/python2.7/site-packages/testtools/testcase.py", line 435, in assertThat
2015-09-22 15:32:21.213 | 2015-09-22 15:32:21.215 | raise mismatch_error
2015-09-22 15:32:21.214 | 2015-09-22 15:32:21.217 | testtools.matchers._impl.MismatchError: u'11.11.11.11' != None

There are no obvious errors in h-eng.log

[Rakesh H S (rh-s)]

The failure is because of the following functionality that was introduced recently:
https://review.openstack.org/#/c/220501/6
https://review.openstack.org/#/c/220502/11

In convergence, there is no Backup Stack. Rollback is treated as another update with previous template.
The restore_after_rollback logic(https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/neutron/port.py#L444 ) will not work for convergence, in fact not called also.

[Sergey Kraynev (skraynev)]

Rakesh: thank you for the analyzing this issue. Your are right.
I suggest to chat about possible solution for convergence case.

[Rakesh H S (rh-s)]

I have done temporary fix for this issue will push soon and we can discuss on the same.

[Rakesh H S (rh-s)]

In convergence when updating with previous template(Rollback) we fetch the previous resources from db here:
https://github.com/openstack/heat/blob/master/heat/engine/stack.py#L1042

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228321

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228321
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=ddf84f8ea6cf25a63801a60df05c528d6a5f2b23
Submitter: Jenkins
Branch: master

commit ddf84f8ea6cf25a63801a60df05c528d6a5f2b23
Author: Rakesh H S <email address hidden>
Date: Mon Oct 12 16:47:42 2015 +0530

    Convergence: Fix restore on rollback for server and port

    Implements the special handling required for server and port resources
    rollback to be possible.

    Change-Id: If1b39df070f5e5394304d3e2b31ee7226ec2f270
    Partial-Implements: blueprint rich-network-prop
    Closes-Bug: #1498660

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/242262

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/heat 6.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steve Baker (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/242262