Can't create shares on drivers that don't support snapshots

[Clinton Knight]

The code in host manager that copies host attributes to pools doesn't correctly handle the snapshot_support attribute, so that it isn't possible to provision shares that have supports_snapshot = '<is> False' in the share type.

[Valeriy Ponomaryov (vponomaryov)]

What error you get? How to reproduce? Which driver fails?

It works for me using generic driver disabling some of its snapshot methods. I can not reproduce this bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/226931

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/226931
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=8a34fb3890810330a9b8a2d659739d92134a832c
Submitter: Jenkins
Branch: master

commit 8a34fb3890810330a9b8a2d659739d92134a832c
Author: Clinton Knight <email address hidden>
Date: Wed Sep 23 10:48:34 2015 -0400

    Can't create shares on drivers that don't support snapshots

    For a driver that doesn't support snapshots, a share type with
    snapshot_support = '<is> False' will prevent share creation.
    Root cause is code in HostManager that improperly checks whether
    snapshot_support (and other boolean properties) is set on each
    pool. This commit fixes the check for the boolean pool capabilities.

    Change-Id: I6a488788926cca119498b3de992beec3b0545259
    Closes-Bug: #1498646

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/229541

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229541
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=91b88b2167a239f93df5cf41b993261abbc0f4d7
Submitter: Jenkins
Branch: stable/liberty

commit 91b88b2167a239f93df5cf41b993261abbc0f4d7
Author: Clinton Knight <email address hidden>
Date: Wed Sep 23 10:48:34 2015 -0400

    Can't create shares on drivers that don't support snapshots

    For a driver that doesn't support snapshots, a share type with
    snapshot_support = '<is> False' will prevent share creation.
    Root cause is code in HostManager that improperly checks whether
    snapshot_support (and other boolean properties) is set on each
    pool. This commit fixes the check for the boolean pool capabilities.

    Change-Id: I6a488788926cca119498b3de992beec3b0545259
    Closes-Bug: #1498646
    (cherry picked from commit 8a34fb3890810330a9b8a2d659739d92134a832c)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/235328

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235328
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=ec94d6929ea8e1b4ce10dc91cd4954ece808668c
Submitter: Jenkins
Branch: master

commit f1eded1fbcaf309e1c9a4be3f8a14bd25daa3e46
Author: Gaurang Tapase <email address hidden>
Date: Mon Oct 12 20:47:19 2015 +0530

    Fix usage of dependencies

    Manila is broken is threee places, so fix them:
    1) test 'test_misc' with WebOb 1.5

    WebOb 1.5 was released at 2015-10-11. With this new version,
    webob.exc.WSGIHTTPException() constructor now fails with a KeyError
    when the HTTP status code is 0.

    test_exceptions_raise() of test_misc tries to instantiate all
    exceptions of manila.exception. The problem is that
    ConvertedException uses a default HTTP status code of 0.

    Modify the default HTTP status code of ConvertedException to 400 to
    fix the unit tests.

    2) Add dependency for 'testresources' that is required by migration
    tests.

    3) Remove 2 unit tests related to testing of oslo.policy lib
    functionality that should not be tested in Manila. It started failing
    because under-the-hood behaviour was changed in new realese 0.12.0

    Closes-Bug: #1505153
    Closes-Bug: #1505374

    (cherry picked from commit 9c99814ce5943bd4c33bf3650b832666e31b3411)

    -- squashed with another change to get tests to pass on stable/liberty --

    Fix broken unit tests

    With release of six module version 1.10.0 several our unit tests
    started to fail because of usage of not strict constructions.

    Changes:
    1) Manila unit test
    "manila.tests.share.test_api.ShareAPITestCase.test_extend_quota_error"
    used str for int substitution. So, use int data for int substitution.

    2) Module 'manila.share.drivers.hp.hp_3par_mediator' was using
    LOG.exception function when no traceback were exist it led to
    AttributeError on py34. So, replace all usages of 'LOG.exception'
    with 'LOG.error' where no raised exceptions exist.

    Change-Id: Ic5b37bfb9d939d03f6ff68bc53d134bf9e5f996e
    Closes-Bug: #1503969
    (cherry picked from commit f38b8d4efd1f68f4ea29747f7377e0936f61d89c)

    --

    Change-Id: I0f28f3c3fb2c7eec1bafc3a617344990f86810cf

commit 151b691bb2d4baa436913924df60b8c197f91463
Author: Valeriy Ponomaryov <email address hidden>
Date: Thu Oct 1 12:42:05 2015 +0300

    Fix display of availability-zone for manila-manage command

    Commands "manila-manage service list" and "manila-manage host list"
    were displaying availability zone instance instead of its name.

    Such bug appeared after implementation of Availability zone model.
    So, fix it by providing 'name' field of availability zone model.

    Change-Id: I14c3451380df01853183aed265344b1783c95939
    Closes-Bug: #1499677

commit 77455a5ac6be828e8dfd3e75566eaff2823595d4
Author: Csaba Henk <email address hidden>
Date: Wed Sep 30 14:57:00 2015 +0200

    glusterfs_native: use dynamic-auth option if available

    With dynamic-auth restarting the volume is not necessary
    in deny_access.

    Change-Id: Ic25af1795c279b34370...

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/manila 2.0.0.0b1 development milestone.