Inconsistent keyword parameter in fuel-qa update_yaml

[Alexandr Kostrikov]

Keyword parameter in update_yaml in helpers/utils.py has following signature

is_uniq - If true, add the unique two-digit suffix to the variable name.

https://github.com/stackforge/fuel-qa/blob/stable/7.0/fuelweb_test/helpers/utils.py#L182-L214

>>> update_yaml(['test'], '{:.2f}'.format(21), is_uniq=True, yaml_file=yaml_path)
>>> update_yaml(['test'], '{:.2f}'.format(23), is_uniq=False, yaml_file=yaml_path)
>>> update_yaml(['test'], '{:.2f}'.format(23), is_uniq=False, yaml_file=yaml_path)
>>> update_yaml(['test'], '{:.2f}'.format(44), is_uniq=True, yaml_file=yaml_path)

cat test.yaml
test: '44.00'
test_00: '23.00'
test_01: '23.00'

As it is clear False is working as True and True is working as False. This is due to lines at
https://github.com/stackforge/fuel-qa/blob/stable/7.0/fuelweb_test/helpers/utils.py#L203-L206

if is_uniq:
        last = yaml_tree[-1]
    else:
        # Create an uniq suffix in range '_00' to '_99'

Bug has no effects on end-user because it is used only in one place and is adapted to work properly

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/235212

[Dennis Dmitriev (ddmitriev)]

Looks like there is a mistake in description for 'is_uniq' in docstring. is_uniq=True should mean 'overwrite the same variable', is_uniq=False should mean 'store values separately with shuffix _NN'.

<uniq> means here that there is only one value for some variable, without any duplicates.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235212
Committed: https://git.openstack.org/cgit/stackforge/fuel-qa/commit/?id=ed02e1b6a65516fa85d3c34ce5738f32480dffa3
Submitter: Jenkins
Branch: master

commit ed02e1b6a65516fa85d3c34ce5738f32480dffa3
Author: vgorin <email address hidden>
Date: Thu Oct 15 13:00:55 2015 +0300

    Change decription of is_uniq value in update_yaml, which can mislead

    Change-Id: Ie245ca5fc7b9b87ea55ac0af08baec1dca1e403e
    Closes-Bug: #1498567