Can't change Node name via Fuel CLI

Bug #1498523 reported by Damian Szeluga
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Invalid
Medium
Fuel Python (Deprecated)
7.0.x
Fix Released
Medium
Rodion Tikunov
8.0.x
Fix Released
Medium
Fuel Python (Deprecated)
Mitaka
Won't Fix
Medium
Fuel Python (Deprecated)
Newton
Invalid
Medium
Fuel Python (Deprecated)

Bug Description

There's no option to change fuel node name (f.e. Untitled aa:bb) to something meaningful using CLI.
It's doable using Web UI, but some prefer to do that using CLI.

Changed in fuel:
milestone: none → 8.0
importance: Undecided → High
importance: High → Medium
assignee: nobody → Fuel Python Team (fuel-python)
status: New → Confirmed
tags: added: feature module-client
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Sylwester Brzeczkowski (sbrzeczkowski)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/227236

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/227327

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/227327
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=3cc0700d7fc710b49d3d65cf163275b12fe41d1d
Submitter: Jenkins
Branch: master

commit 3cc0700d7fc710b49d3d65cf163275b12fe41d1d
Author: Sylwester Brzeczkowski <email address hidden>
Date: Thu Sep 24 16:10:45 2015 +0200

    Change node name from CLI (fuel2)

    Added new updatable attribute to NodeUpdate action:
    `fuel2 node update 1 --name NewName`

    Also test added.

    Change-Id: If1174ede30b849ab1fc357823e9624b98ca7ec7e
    Partial-Bug: #1498523

Dmitry Pyzhov (dpyzhov)
tags: added: area-python
tags: added: customer-found
Anton Matveev (amatveev)
tags: added: sla2
Revision history for this message
Alexander Rubtsov (arubtsov) wrote :

sla2 for MOS 7.0

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/227236
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=6810231ec6d333fc10f7020f9bdf5122e05e998a
Submitter: Jenkins
Branch: master

commit 6810231ec6d333fc10f7020f9bdf5122e05e998a
Author: Sylwester Brzeczkowski <email address hidden>
Date: Thu Sep 24 13:16:25 2015 +0200

    Change node name from CLI (fuel1)

    Added possibility to change node name:
    `fuel node --node-id --name NewName`
    The functionality for fuel2 has been already merged
    in separate patch.

    Also unit tests added.

    Change-Id: I6d3384d1615bdd1dbb53508a0c2908e62f05898b
    Partial-Bug: #1498523

Revision history for this message
Anton Matveev (amatveev) wrote :

both patches (for fuel1, fuel2) were merged to master (current 8.0).
status of ticket for 8.0 should be "fix commited"

Changed in fuel:
milestone: 8.0 → 9.0
Changed in fuel:
assignee: Sylwester Brzeczkowski (sbrzeczkowski) → Fuel Python Team (fuel-python)
tags: added: on-verification
Revision history for this message
Mikhail Samoylov (msamoylov) wrote :

Checked in fuel version:
[root@nailgun ~]# fuel node --node-id 2 --name NewName
Name for node with id 2 has been changed to NewName.
[root@nailgun ~]# cat /etc/fuel/version.yaml
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "478"
  build_id: "478"
  fuel-nailgun_sha: "ae949905142507f2cb446071783731468f34a572"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "481ed135de2cb5060cac3795428625befdd1d814"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "420c6fa5f8cb51f3322d95113f783967bde9836e"
  fuel-ostf_sha: "ab5fd151fc6c1aa0b35bc2023631b1f4836ecd61"
  fuel-mirror_sha: "b62f3cce5321fd570c6589bc2684eab994c3f3f2"
  fuelmenu_sha: "fac143f4dfa75785758e72afbdc029693e94ff2b"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "9f0ba4577915ce1e77f5dc9c639a5ef66ca45896"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "6c6b088a3d52dd0eaf43d59f3a3a149c93a07e7e

Steps:
1. Execute command fuel node --node-id --name NewName
2. Execute command fuel2 node update 1 --name NewName
Expected result : name was changed
Output result: http://paste.openstack.org/show/485264/

tags: removed: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (stable/7.0)

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/273578

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/273583

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (stable/7.0)

Reviewed: https://review.openstack.org/273578
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=efc5774e856a18fb9ca01ba7f53c309fcb109cf4
Submitter: Jenkins
Branch: stable/7.0

commit efc5774e856a18fb9ca01ba7f53c309fcb109cf4
Author: Sylwester Brzeczkowski <email address hidden>
Date: Thu Sep 24 13:16:25 2015 +0200

    Change node name from CLI (fuel1)

    Added possibility to change node name:
    `fuel node --node-id --name NewName`
    The functionality for fuel2 has been already merged
    in separate patch.

    Also unit tests added.

    Change-Id: I6d3384d1615bdd1dbb53508a0c2908e62f05898b
    Partial-Bug: #1498523
    (cherry picked from commit 6810231ec6d333fc10f7020f9bdf5122e05e998a)
    added some requirement for tests

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/273583
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=fdd57f8c7a8f27d8b98a0c1b232c43847de95cbf
Submitter: Jenkins
Branch: stable/7.0

commit fdd57f8c7a8f27d8b98a0c1b232c43847de95cbf
Author: Sylwester Brzeczkowski <email address hidden>
Date: Thu Sep 24 16:10:45 2015 +0200

    Change node name from CLI (fuel2)

    Added new updatable attribute to NodeUpdate action:
    `fuel2 node update 1 --name NewName`

    Also test added.

    Change-Id: If1174ede30b849ab1fc357823e9624b98ca7ec7e
    Partial-Bug: #1498523
    (cherry picked from commit 3cc0700d7fc710b49d3d65cf163275b12fe41d1d)

tags: added: on-verification
Revision history for this message
TatyanaGladysheva (tgladysheva) wrote :

Verification is suspended because fix is not ready.

Revision history for this message
TatyanaGladysheva (tgladysheva) wrote :

Move to Confirmed status because fix is not available in 7.0 mu3.

tags: removed: on-verification
Revision history for this message
Vitaly Sedelnik (vsedelnik) wrote :

Retargeted to 7.0-mu-4 - https://bugs.launchpad.net/fuel/+bug/1561431 needs to be fixed to enable gate job to succeed

tags: added: on-verification
Revision history for this message
TatyanaGladysheva (tgladysheva) wrote :

Verified on MOS 7.0 mu4 updates.

Steps:
1. Execute command: fuel node --node-id 1 --name NewName
2. Execute command: fuel2 node update 2 --name NewName

Actual result: Name was changed.
Please see https://paste.mirantis.net/show/2320/

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.