Read-only shares in Quobyte Backend are RW indeed

Bug #1498401 reported by Silvan Kaiser
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Critical
Silvan Kaiser

Bug Description

The string `access_level` won't ever be equal to `ro`as implemented in quobyte.py

Fix should be : retrieve the `access_level` value from the `access` dict and compare the result

Tags: driver quobyte
Changed in manila:
assignee: nobody → Silvan Kaiser (2-silvan)
status: New → In Progress
Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :

It is security issue for QuoByte driver that should be fixed, so setting status "critical" and RC1 candidate.

Changed in manila:
milestone: none → liberty-rc1
importance: Undecided → Critical
tags: added: driver quobyte
summary: - Read-only shares in Quobyte Backend
+ Read-only shares in Quobyte Backend are RW indeed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/191075
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=ec1d7878858076c58001343a5127e96879fde04f
Submitter: Jenkins
Branch: master

commit ec1d7878858076c58001343a5127e96879fde04f
Author: Nicolas Trangez <email address hidden>
Date: Fri Jun 12 15:43:44 2015 +0200

    Make Quobyte shares actually read-only when requested

    The string `access_level` won't ever be equal to `ro` in Quobyte Driver.
    Do the right thing:
    retrieve the `access_level` value from the `access` dict and
    compare the result, as most likely intended but incorrectly implemented
    and not tested. Also add the missing test.

    Closes-Bug: 1498401

    Change-Id: I735e5d0c91b5c8b258f4aa3461731ff293784995

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: liberty-rc1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.