Fix promote for Redis datastore

[Peter Stachowski]

The 'set' command in the Python client interpretes None as the
string 'None.' If no password is set on the master, a detach/attach
(such as is done with promote) will have the slave try and use 'none'
as a password. This will leave the slaves in a detached state.

The 'masterpass' should be set to an empty string. The restart of Redis
also needs to be moved before attaching the slave, so that the mapped
CONFIG command is recognized properly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/226075

[Craig Vyvial (cp16net)]

This bug fix should be considered for backport to Liberty for RC2

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/226075
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=6c4db5d327df7e10f7a0bf38deaee0db4fe2ee5a
Submitter: Jenkins
Branch: master

commit 6c4db5d327df7e10f7a0bf38deaee0db4fe2ee5a
Author: Peter Stachowski <email address hidden>
Date: Mon Sep 21 18:00:56 2015 -0400

    Fix promote for Redis datastore

    The 'set' command in the Python client interpretes None as the
    string 'None.' If no password is set on the master, a detach/attach
    (such as is done with promote) will have the slaves try and use 'none'
    as a password. This will cause them to not be able to connect to the
    master and leave them in a detached state.

    The 'masterpass' is now set to an empty string if no password is set.
    The restart of Redis was also moved before attaching the slave,
    so that the mapped CONFIG command is recognized properly. This is
    required so that setting the master password completes successfully.

    Closes-Bug: #1498208
    Change-Id: Ibc842b95fd191908d4fac420030f84393c696013
    Depends-On: Ida0aa155b1e1ec7b8e9fa73006d3db9a88ffea02

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/230335

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/230335
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=5bc4d898634006acaef66dc07bffe7bdc6730dcf
Submitter: Jenkins
Branch: stable/liberty

commit 5bc4d898634006acaef66dc07bffe7bdc6730dcf
Author: Peter Stachowski <email address hidden>
Date: Mon Sep 21 18:00:56 2015 -0400

    Fix promote for Redis datastore

    The 'set' command in the Python client interpretes None as the
    string 'None.' If no password is set on the master, a detach/attach
    (such as is done with promote) will have the slaves try and use 'none'
    as a password. This will cause them to not be able to connect to the
    master and leave them in a detached state.

    The 'masterpass' is now set to an empty string if no password is set.
    The restart of Redis was also moved before attaching the slave,
    so that the mapped CONFIG command is recognized properly. This is
    required so that setting the master password completes successfully.

    (cherry picked from commit 6c4db5d327df7e10f7a0bf38deaee0db4fe2ee5a)
    Closes-Bug: #1498208
    Change-Id: Ibc842b95fd191908d4fac420030f84393c696013
    Depends-On: Ida0aa155b1e1ec7b8e9fa73006d3db9a88ffea02

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/235145

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235145
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=7dcc70937436a84081aa47913f3d67ee257a487f
Submitter: Jenkins
Branch: master

commit 5bc4d898634006acaef66dc07bffe7bdc6730dcf
Author: Peter Stachowski <email address hidden>
Date: Mon Sep 21 18:00:56 2015 -0400

    Fix promote for Redis datastore

    The 'set' command in the Python client interpretes None as the
    string 'None.' If no password is set on the master, a detach/attach
    (such as is done with promote) will have the slaves try and use 'none'
    as a password. This will cause them to not be able to connect to the
    master and leave them in a detached state.

    The 'masterpass' is now set to an empty string if no password is set.
    The restart of Redis was also moved before attaching the slave,
    so that the mapped CONFIG command is recognized properly. This is
    required so that setting the master password completes successfully.

    (cherry picked from commit 6c4db5d327df7e10f7a0bf38deaee0db4fe2ee5a)
    Closes-Bug: #1498208
    Change-Id: Ibc842b95fd191908d4fac420030f84393c696013
    Depends-On: Ida0aa155b1e1ec7b8e9fa73006d3db9a88ffea02

commit 37aea11d771eb7cb7706ea9f5f641cbe42a72fc8
Author: Doug Shelley <email address hidden>
Date: Tue Sep 29 02:41:30 2015 +0000

    Fix publish_exists_event authentication exception

    The nova client created by create_nova_admin_client was throwing
    an Authentication exception. In order to properly create this client,
    novaclient needs tenant_id set to a tenant-id. Note: novaclient
    documents that project-id is specifically a tenant-name and from
    what I can tell it isn't required for Trove use-cases.

    Added a unit test to check that create_nova_admin_client causes
    a nova client to get instantiated with the correct params.

    (cherry picked from commit e1538ae75e37b14905893d91c45dd044d32a7eb0)
    Change-Id: I34d7d9dd36117bff796db22b851656ba78988558
    Closes-bug: 1473550

commit 98ff71917e209e19223105921c2a50c3d89cd2ad
Author: Andreas Jaeger <email address hidden>
Date: Thu Sep 24 21:25:48 2015 +0200

    Cleanup of Translations

    In preparation for the release, do some cleanups for translations.

    Removes all po files that are partially translated. The translation
    team has decided to exclude files with less than 66 % of translated
    content. There is no content lost, all data is in the translation
    server, we just remove it from the repository (not applicable to trove).

    This updates also recreates pot (translation source files) to
    reflect the state of the repository in case there was no recent
    import for them.

    This change needs to be done manually since the automatic import does
    not handle some of these cases.

    Change-Id: Iefe0a9ce6f980fdc1f107e9bb25a171fd505b135

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/trove 5.0.0.0b1 development milestone.