ovs_neutron_agent doesn't start on Windows because validate_local_ip_method uses linux specific implementation

Bug #1497940 reported by Adelina Tuvenie
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Critical
Adelina Tuvenie

Bug Description

Change I4b4527c28d0738890e33b343c9e17941e780bc24 introduced a validate_local_ip sanity check for the local_ip to see that it belongs to the host. This method uses linux specific implementation [1] that fails on windows.

[1] https://review.openstack.org/#/c/154043/13/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py

Revision history for this message
Assaf Muller (amuller) wrote :

Is there CI for the OVS agent on Windows?

summary: - ovs_neutron_agent doesn't start because validate_local_ip_method uses
- linux specific implementation
+ ovs_neutron_agent doesn't start on Windows because
+ validate_local_ip_method uses linux specific implementation
Revision history for this message
Adelina Tuvenie (atuvenie) wrote :

@amuller We are working on a CI for the OVS agent, this is a blocking issue

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/227077

Changed in neutron:
assignee: nobody → Adelina Tuvenie (atuvenie)
status: New → In Progress
tags: added: liberty-rc-potential
Akihiro Motoki (amotoki)
tags: added: liberty-backport-potential
removed: liberty-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/227077
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in neutron:
status: In Progress → Incomplete
assignee: Adelina Tuvenie (atuvenie) → nobody
Changed in neutron:
assignee: nobody → Adelina Tuvenie (atuvenie)
status: Incomplete → In Progress
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

If you are still working on this please resume, or allow someone else to pick this up.

Changed in neutron:
status: In Progress → Incomplete
assignee: Adelina Tuvenie (atuvenie) → nobody
Changed in neutron:
assignee: nobody → Adelina Tuvenie (atuvenie)
status: Incomplete → In Progress
Changed in neutron:
importance: Undecided → Critical
milestone: none → mitaka-rc1
Changed in neutron:
milestone: mitaka-rc1 → newton-1
tags: added: mitaka-rc-potential
tags: added: mitaka-backport-potential
removed: mitaka-rc-potential
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

@Hirofumi: any reason why you flipped the rc-potential tag? Ideally we'd ship Mitaka with a working hyper-v ovs agent.

tags: added: mitaka-rc-potential
removed: mitaka-backport-potential
Revision history for this message
Hirofumi Ichihara (ichihara-hirofumi) wrote :

@Armando: Sorry. I didn't understand the tag is valid after RC1 cut off. So I thought it's sipped to Newton and then backported in Mitaka. However, we have RC2 now, right?

Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

Not yet.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/227077
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=371e8aa0769086d069cc9005f1c454fb348afd46
Submitter: Jenkins
Branch: master

commit 371e8aa0769086d069cc9005f1c454fb348afd46
Author: Adelina Tuvenie <email address hidden>
Date: Wed Sep 23 17:59:11 2015 -0700

    Ovs agent can't start on Windows because of validate_local_ip

    Change I4b4527c28d0738890e33b343c9e17941e780bc24 introduced a
    validate_local_ip sanity check for the local_ip to see that it
    belongs to the host.

    This method uses linux specific implementation that fails on windows.

    This patch fixes this bug by adding a implementation for
    validate_local_ip that works on windows as well, using netifaces.

    Change-Id: Ia8299512687d9d7135fe013fbb38f2b28d54125d
    Closes-Bug: #1497940

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/295276

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/mitaka)

Reviewed: https://review.openstack.org/295276
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2b823de315aaca85bbafb020631f34b3fb233998
Submitter: Jenkins
Branch: stable/mitaka

commit 2b823de315aaca85bbafb020631f34b3fb233998
Author: Adelina Tuvenie <email address hidden>
Date: Wed Sep 23 17:59:11 2015 -0700

    Ovs agent can't start on Windows because of validate_local_ip

    Change I4b4527c28d0738890e33b343c9e17941e780bc24 introduced a
    validate_local_ip sanity check for the local_ip to see that it
    belongs to the host.

    This method uses linux specific implementation that fails on windows.

    This patch fixes this bug by adding a implementation for
    validate_local_ip that works on windows as well, using netifaces.

    Change-Id: Ia8299512687d9d7135fe013fbb38f2b28d54125d
    Closes-Bug: #1497940
    (cherry picked from commit 371e8aa0769086d069cc9005f1c454fb348afd46)

tags: added: in-stable-mitaka
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.0.0.0rc2

This issue was fixed in the openstack/neutron 8.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/302570

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)
Download full text (11.4 KiB)

Reviewed: https://review.openstack.org/302570
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=03ccdd6a6d8e4cea9145e39dd7a1614656024aed
Submitter: Jenkins
Branch: master

commit 3213eb124e40b130e174ac3a91067e2b196788dd
Author: Cedric Brandily <email address hidden>
Date: Tue Mar 29 18:06:44 2016 +0200

    Support Routes==2.3

    SubMapper.connect allows in Routes<=2.2 to define routes with/without a
    name:

     map.connect(route_name, route_path)
     map.connect(route_path)

    Routes==2.3 SubMapper.connect now requires a route name (but not
    Mapper.connect). This change adds a route name when needed to support
    Routes<=2.2 and Routes==2.3.

    Closes-Bug: #1563028
    Change-Id: I655bfe7f047945896d63dd94c584acfe60d81b38
    (cherry picked from commit c6efa6292cac9267428366dc3cee00f6fc73e208)

commit 4283a7e36b74823f229400f0f049742f630db28b
Author: Ihar Hrachyshka <email address hidden>
Date: Wed Mar 30 11:48:37 2016 +0200

    Constraint requirements using mitaka upper-constraints.txt file

    Change-Id: I6a908470987ce05769c425c4623df404cef76a10

commit fc690974480611242d4fc6e1deaaf68171fcaed3
Author: OpenStack Proposal Bot <email address hidden>
Date: Wed Mar 30 06:21:15 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I78c24969927224277f381532ad2604cfde8741fc

commit 41be555eddb0f9947fdaa4e73fa74a72677d4d11
Author: OpenStack Proposal Bot <email address hidden>
Date: Tue Mar 29 06:07:19 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: Iafa43bfcfca4d6af0d0866206c07fa817f567de6

commit b435ec56af98d2c04de37dd779ed3613ec4583ad
Author: OpenStack Proposal Bot <email address hidden>
Date: Mon Mar 28 06:07:02 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I9e908579b4704c4294367113523b898839586426

commit bec65f6cdd159ec252c4aa0a63aabc9aea8fcfba
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Mar 25 15:25:39 2016 +0900

    api tests: Check correct extensions

    auto_allocate -> auto-allocated-topology
    rbac_policies -> rbac-policies

    Closes-Bug: #1561858

    (cherry picked from commit 9d3bab6b8d6b2122732faeb66f831927bee0ac7e)
    Change-Id: Ied13e52bf78afe571f7243e93005bf5c68fe44db

commit f0c3b19165a5ca73ea8f1dc0ddaad290eee35039
Author: OpenStack Proposal Bot <email address hidden>
Date: Fri Mar 25 06:06:36 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: Idb22eac32944a088d24f4d44e537d9bba09dbcc2

commit 99915fa76bd4ce13e0d36059616ba357f4f54ee2
Author: Hynek Mlnarik <email address hidden>
Date: Thu Mar...

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/312606

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/liberty)

Change abandoned by Petrut Lucian (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/312606

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 9.0.0.0b1

This issue was fixed in the openstack/neutron 9.0.0.0b1 development milestone.

tags: removed: liberty-backport-potential mitaka-rc-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.