worker/rsyslog: data race

Bug #1497807 reported by Dave Cheney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
High
Dave Cheney

Bug Description

==================
WARNING: DATA RACE
Read by goroutine 106:
  runtime.convT2E()
      /home/dfc/go/src/runtime/iface.go:131 +0x0
  github.com/juju/juju/worker/rsyslog_test.(*RsyslogSuite).TestModeForwarding()
      /home/dfc/src/github.com/juju/juju/worker/rsyslog/rsyslog_common_test.go:108 +0xd71
  runtime.call32()
      /home/dfc/go/src/runtime/asm_amd64.s:442 +0x3d
  reflect.Value.Call()
      /home/dfc/go/src/reflect/value.go:300 +0xcd
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /home/dfc/src/gopkg.in/check.v1/check.go:772 +0x5d1
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /home/dfc/src/gopkg.in/check.v1/check.go:666 +0x80

Previous write by goroutine 148:
  github.com/juju/juju/worker/rsyslog.(*RsyslogConfigHandler).replaceRemoteLogger()
      /home/dfc/src/github.com/juju/juju/worker/rsyslog/worker.go:246 +0xf21
  github.com/juju/juju/worker/rsyslog.(*RsyslogConfigHandler).Handle()
      /home/dfc/src/github.com/juju/juju/worker/rsyslog/worker.go:271 +0x41a
  github.com/juju/juju/worker.(*notifyWorker).loop()
      /home/dfc/src/github.com/juju/juju/worker/notifyworker.go:103 +0x43f
  github.com/juju/juju/worker.NewNotifyWorker.func1()
      /home/dfc/src/github.com/juju/juju/worker/notifyworker.go:56 +0x65

Goroutine 106 (running) created at:
  gopkg.in/check%2ev1.(*suiteRunner).forkCall()
      /home/dfc/src/gopkg.in/check.v1/check.go:667 +0x48b
  gopkg.in/check%2ev1.(*suiteRunner).forkTest()
      /home/dfc/src/gopkg.in/check.v1/check.go:804 +0x126
  gopkg.in/check%2ev1.(*suiteRunner).runTest()
      /home/dfc/src/gopkg.in/check.v1/check.go:809 +0x38
  gopkg.in/check%2ev1.(*suiteRunner).run()
      /home/dfc/src/gopkg.in/check.v1/check.go:615 +0x481
  gopkg.in/check%2ev1.Run()
      /home/dfc/src/gopkg.in/check.v1/run.go:92 +0x50
  gopkg.in/check%2ev1.RunAll()
      /home/dfc/src/gopkg.in/check.v1/run.go:84 +0x138
  gopkg.in/check%2ev1.TestingT()
      /home/dfc/src/gopkg.in/check.v1/run.go:72 +0x4af
  github.com/juju/testing.MgoTestPackage()
      /home/dfc/src/github.com/juju/testing/mgo.go:354 +0x177
  github.com/juju/juju/testing.MgoTestPackage()
      /home/dfc/src/github.com/juju/juju/testing/mgo.go:15 +0x4a
  github.com/juju/juju/worker/rsyslog_test.TestPackage()
      /home/dfc/src/github.com/juju/juju/worker/rsyslog/rsyslog_common_test.go:29 +0x2e
  testing.tRunner()
      /home/dfc/go/src/testing/testing.go:456 +0xdc

Goroutine 148 (running) created at:
  github.com/juju/juju/worker.NewNotifyWorker()
      /home/dfc/src/github.com/juju/juju/worker/notifyworker.go:57 +0xd9
  github.com/juju/juju/worker/rsyslog.newRsyslogConfigWorker()
      /home/dfc/src/github.com/juju/juju/worker/rsyslog/worker.go:106 +0x46e
  github.com/juju/juju/worker/rsyslog_test.(*RsyslogSuite).TestModeForwarding()
      /home/dfc/src/github.com/juju/juju/worker/rsyslog/rsyslog_common_test.go:96 +0x523
  runtime.call32()
      /home/dfc/go/src/runtime/asm_amd64.s:442 +0x3d
  reflect.Value.Call()
      /home/dfc/go/src/reflect/value.go:300 +0xcd
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /home/dfc/src/gopkg.in/check.v1/check.go:772 +0x5d1
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /home/dfc/src/gopkg.in/check.v1/check.go:666 +0x80
==================
OK: 9 passed
PASS
Found 1 data race(s)
FAIL github.com/juju/juju/worker/rsyslog 13.041s

Aaron Bentley (abentley)
Changed in juju-core:
status: New → Triaged
importance: Undecided → High
milestone: none → 1.26-alpha1
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 1.26-alpha1 → 1.26-alpha2
Changed in juju-core:
milestone: 1.26-alpha2 → 1.26-beta1
Changed in juju-core:
assignee: nobody → Dave Cheney (dave-cheney)
status: Triaged → In Progress
Changed in juju-core:
status: In Progress → Fix Committed
Changed in juju-core:
milestone: 1.26-beta1 → 2.0-alpha1
Changed in juju-core:
milestone: 2.0-alpha1 → 1.26-alpha3
Curtis Hovey (sinzui)
tags: added: race-condition tech-debt
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.