tests/libqos/ahci.c:745: redundant condition ?

[dcb]

[qemu/tests/libqos/ahci.c:745]: (style) Redundant condition: props.ncq. '!props.ncq || (props.ncq && props.lba48)' is equivalent to '!props.ncq || props.lba48'

    g_assert(!props->ncq || (props->ncq && props->lba48));

[Stefan Hajnoczi (stefanha)]

On Sun, Sep 20, 2015 at 10:08:49AM -0000, dcb wrote:
> Public bug reported:
>
> [qemu/tests/libqos/ahci.c:745]: (style) Redundant condition: props.ncq.
> '!props.ncq || (props.ncq && props.lba48)' is equivalent to '!props.ncq
> || props.lba48'
>
> g_assert(!props->ncq || (props->ncq && props->lba48));

CCing John Snow, AHCI maintainer

[Stefan Hajnoczi (stefanha)]

Fixed in:

commit 3d937150dce20cb95cbaae99b6fd48dca4261f32
Author: John Snow <email address hidden>
Date: Mon Oct 5 12:00:55 2015 -0400

    qtest/ahci: fix redundant assertion

    Fixes https://bugs.launchpad.net/qemu/+bug/1497711

    (!ncq || (ncq && lba48)) is the same as
    (!ncq || lba48).

    The intention is simply: "If a command is NCQ,
    it must also be LBA48."

    Signed-off-by: John Snow <email address hidden>
    Message-id: <email address hidden>