Feed logo image displays a broken image

[Robin Leung]

If you add a new external RSS feed, it displays the feed but the "feedlogoimage" displays a broken image.

Using:
- Mahara 15.04.1
- Windows and OSX
- MYSQL
- Firefox (latest version)

[Mahara Bot (dev-mahara)]

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5317

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/5318

[Robert Lyon (robertl-9)]

The patches for master and 15.04 are slightly different

[Mahara Bot (dev-mahara)]

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5343

[Aaron Wells (u-aaronw)]

Test procedure:

1. Create a page
2. On the page, create an external feed block with this URL (which is a feed without a logo image): http://blogs.kwantlen.ca/sites/learntech/feed/
3. Also on the page, create an external feed block with this URL (which is a feed *with* a logo image): http://rss.earwolf.com/comedy-bang-bang
4. View the page

Expected result: The Kwantlen feed should display without a logo or a broken image. The Comedy Bang Bang feed should display with its logo image

One thing to note, is that the RSS feed logo will not display if the logo's URL is http and your site is https. That is a separate issue: https://bugs.launchpad.net/mahara/+bug/1234582

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/5344

[Robin Leung (robin-leung)]

Thanks for the quick fix! It works.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/5344
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/2389c72b9bdf7e1e893de2192edf67bdbb0e8924
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 2389c72b9bdf7e1e893de2192edf67bdbb0e8924
Author: Aaron Wells <email address hidden>
Date: Wed Sep 23 17:54:21 2015 +1200

sanitize_url() should return false, when given a null URL (Bug 1497411)

It turns out that if you pass NULL to parse_url(), it returns:
array('path'=>''). Since we were checking isset($parsedurl['path']), this
returns true, even though the url was bad.

behatnotneeded: Already covered by existing tests

Change-Id: I5f4a6074981e6853988225858c22d9dcb0c43feb

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/5318
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/4308b06b3a97065c69a41ceaa310fda5c75c40c3
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 4308b06b3a97065c69a41ceaa310fda5c75c40c3
Author: Robert Lyon <email address hidden>
Date: Mon Sep 21 12:11:25 2015 +1200

Bug 1497411: Display RSS feed's image

behatnotneeded: Can't be checked by behat

Change-Id: Ia0de29f581e515ad5410139f6f0a8ce616ecf71f
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/5317
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/c6e09db153e38da7bc6f1766e6419c3051d15ef9
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.04_STABLE

commit c6e09db153e38da7bc6f1766e6419c3051d15ef9
Author: Aaron Wells <email address hidden>
Date: Wed Sep 23 17:54:21 2015 +1200

sanitize_url() should return false, when given a null URL (Bug 1497411)

It turns out that if you pass NULL to parse_url(), it returns:
array('path'=>''). Since we were checking isset($parsedurl['path']), this
returns true, even though the url was bad.

behatnotneeded: Already covered by existing tests

Change-Id: I6ecb2468537b4754a35c76e3a4ee4a6ef6078229