snappy list/remove bails on 15.04/stable #5 if invalid package.yaml is on disk (no vendor field)

Bug #1497245 reported by Alexander Sack
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snappy
Fix Released
High
John Lenton

Bug Description

snappy list
can not parse package.yaml: missing required fields 'vendor' (from: "name: xxx-zigbee-gateway\nversion: 0.0.1\nVendor: Roger Roger <email address hidden>\nicon: meta/hello.svg\nbinaries:\n - name: bin/usr/local/bin/node\n caps: []\n#explicit-license-agreement: Y\n")

would be great if our code would be as robust as possible and continues no matter what. as long as the info needed for the essential parts of the operation is there...

remove should surely always work. list might skip this package or mark it as broken.

Alexander Sack (asac)
summary: - snappy list/remove explodes if invalid package.yaml is on disk
+ snappy list/remove bails on 15.04/stable #5 if invalid package.yaml is
+ on disk (no vendor field)
Changed in snappy:
importance: Undecided → High
assignee: nobody → John Lenton (chipaca)
milestone: none → 15.04.4
description: updated
Revision history for this message
Leo Arias (elopio) wrote :

The snaps are now mounted read only, so the only way to list or remove a snap with an invalid yaml would be for it to be invalid during the installation. That fails, and a test was added to make sure that it is an error and not a panic: https://github.com/ubuntu-core/snappy/pull/885/files#diff-d9d39acdde768abd2891cd21d5c9aeceR566

Changed in snappy:
status: New → Fix Committed
milestone: 15.04.4 → 16.04-beta1
Michael Vogt (mvo)
Changed in snappy:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.