image create --volume command (v1) will attempt to create two images

[Niall Bunting]

When running the following command:

openstack image create MyNewImage --volume 1d283b0c-b38d-4773-9df4-18a49f305c43

Openstack client will return the following:
ERROR: openstack create() got an unexpected keyword argument 'volume'

What has happened:
The image was created by the cinder upload to image command. Then it tried to create an image but the keyword volume causes this to error out.

Consequences:
The user will think the command has not worked, when in fact they created the image.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/225195

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/225195
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=1afd8f62cd5b59c9bd3042af6dbc4ba94717c023
Submitter: Jenkins
Branch: master

commit 1afd8f62cd5b59c9bd3042af6dbc4ba94717c023
Author: NiallBunting <email address hidden>
Date: Fri Sep 18 15:21:59 2015 +0000

    Image fix bug with --volume

    Currently after calling the cinderclient to create an image from a volume,
    it also then tries to create another image. This fails as the keyword
    volume is unexpected. This add checks so the image is not created in
    this case. Allowing --volume to not throw an error when it has worked.

    Change-Id: I67e650eb0b8c331d86515e3e326c39a5d6dad5e1
    Closes-Bug: 1497221

[Steve Martinelli (stevemar)]

this was released in 1.8.0