[DVR] Not correct rescheduling while agents are unstable

[Kristina Berezovskaia]

After reseting primary controller connection to the internet and other vms was lost. This case didn't appeared permanently

Steps:
1) Create net, subnet and connect them to external net with DVR router
2) Launch vm in new net and associate floating ip
3) Check connection to internet
4) Reset primary controller
5) Wait some minutes
6) Check connectivity
Expected result: ping 8.8.8.8 works properly
Current result: Message "Network is unteachable"

iso (vxlan + l2 + dvr):
{"build_id": "296", "build_number": "296", "release_versions": {"2015.1.0-7.0": {"VERSION": {"build_id": "296", "build_number": "296", "api": "1.0", "fuel-library_sha": "f2eef7717b15c6c0a3e76ef98ad4c7c4532d56f9", "nailgun_sha": "16a39d40120dd4257698795f12de4ae8200b1778", "feature_groups": ["mirantis"], "fuel-nailgun-agent_sha": "d7027952870a35db8dc52f185bb1158cdd3d1ebd", "openstack_version": "2015.1.0-7.0", "fuel-agent_sha": "082a47bf014002e515001be05f99040437281a2d", "production": "docker", "python-fuelclient_sha": "2864459e27b0510a0f7aedac6cdf27901ef5c481", "astute_sha": "6c5b73f93e24cc781c809db9159927655ced5012", "fuel-ostf_sha": "1f08e6e71021179b9881a824d9c999957fcc7045", "release": "7.0", "fuelmain_sha": "6b83d6a6a75bf7bca3177fcf63b2eebbf1ad0a85"}}}, "auth_required": true, "api": "1.0", "fuel-library_sha": "f2eef7717b15c6c0a3e76ef98ad4c7c4532d56f9", "nailgun_sha": "16a39d40120dd4257698795f12de4ae8200b1778", "feature_groups": ["mirantis"], "fuel-nailgun-agent_sha": "d7027952870a35db8dc52f185bb1158cdd3d1ebd", "openstack_version": "2015.1.0-7.0", "fuel-agent_sha": "082a47bf014002e515001be05f99040437281a2d", "production": "docker", "python-fuelclient_sha": "2864459e27b0510a0f7aedac6cdf27901ef5c481", "astute_sha": "6c5b73f93e24cc781c809db9159927655ced5012", "fuel-ostf_sha": "1f08e6e71021179b9881a824d9c999957fcc7045", "release": "7.0", "fuelmain_sha": "6b83d6a6a75bf7bca3177fcf63b2eebbf1ad0a85"}

[Oleg Bondarev (obondarev)]

The bug is that if only 'dvr' (on computes) agents are active at the moment of DVR router rescheduling - the router will be rescheduled only on them and rescheduling will be considered as successful. The fix would be to fail if snat was not scheduled.

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: Oleg Bondarev <email address hidden>
Review: https://review.fuel-infra.org/11769

[Oleg Bondarev (obondarev)]

Workaround: do any operation with router to trigger rescheduling, like gateway port or internal interface attach/detach, floating_ip associate/disassociate, vm spawn/delete.

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-8.0/liberty
Change author: Oleg Bondarev <email address hidden>
Review: https://review.fuel-infra.org/14747

[Sergii Rizvan (srizvan)]

The bug was reproduced in very rare case, also it doesn't have affected customers and workaround exists. That's why we are about to decrease priority to Medium and close it as Won't Fix for 7.0.

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Sergii Rizvan <email address hidden> on branch: openstack-ci/fuel-7.0/2015.1.0
Review: https://review.fuel-infra.org/11769
Reason: Change abandoned due to https://bugs.launchpad.net/mos/7.0.x/+bug/1497143/comments/5

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/14747
Submitter: Pkgs Jenkins <email address hidden>
Branch: openstack-ci/fuel-8.0/liberty

Commit: 5332b06e95ad111ee0dee70fc7414d174ed96864
Author: Oleg Bondarev <email address hidden>
Date: Fri Dec 18 07:58:28 2015

DVR: rescheduling should fail if snat was not rescheduled

If router has external gateway we need to ensure that snat portion
was rescheduled or fail.

Closes-Bug: #1497143
Change-Id: I4696bae4eea43b2856ad457db9d74edf931de869

[Kristina Berezovskaia (kkuznetsova)]

Verify on
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "361"
  build_id: "361"
  fuel-nailgun_sha: "53c72a9600158bea873eec2af1322a716e079ea0"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "7463551bc74841d1049869aaee777634fb0e5149"
  fuel-nailgun-agent_sha: "92ebd5ade6fab60897761bfa084aefc320bff246"
  astute_sha: "c7ca63a49216744e0bfdfff5cb527556aad2e2a5"
  fuel-library_sha: "ba8063d34ff6419bddf2a82b1de1f37108d96082"
  fuel-ostf_sha: "889ddb0f1a4fa5f839fd4ea0c0017a3c181aa0c1"
  fuel-mirror_sha: "8adb10618bb72bb36bb018386d329b494b036573"
  fuelmenu_sha: "824f6d3ebdc10daf2f7195c82a8ca66da5abee99"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "9f0ba4577915ce1e77f5dc9c639a5ef66ca45896"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "07d5f1c3e1b352cb713852a3a96022ddb8fe2676"
(neutron+dvr)
After resetting primary controller many times, there are no problems with message "Network is unteachable"

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: 9.0/mitaka
Change author: Oleg Bondarev <email address hidden>
Review: https://review.fuel-infra.org/18407

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Oleg Bondarev <email address hidden> on branch: 9.0/mitaka
Review: https://review.fuel-infra.org/18407
Reason: Not needed since bp/improve-dvr-l3-agent-binding was implemented in Mitaka