Improve performance of _get_dvr_sync_data

Bug #1496974 reported by Ryan Moats
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Carl Baldwin
Kilo
Fix Released
Undecided
Unassigned

Bug Description

Today, when scheduling a router to a host, _get_dvr_sync_data makes a call to get all ports on that host. This causes the time to schedule a new router to increase as the number of routers on the host increases.

What can we do to improve performance by limiting the number of ports that we need to return to the agent?

Marked high and kilo-backport-potential because the source problem is in an existing operator cloud running stable/kilo

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/224878

Changed in neutron:
assignee: nobody → Ryan Moats (rmoats)
status: New → In Progress
Revision history for this message
Ryan Moats (rmoats) wrote :

Launchpad appears to have missed this:

Fix proposed to branch: master
Review: https://review.openstack.org/#/c/224323/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/kilo)

Change abandoned by Ryan Moats (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/224878
Reason: Abandoning change as it doesn't appreciably improve performance in kilo (i.e. kilo doesn't need it)

Ryan Moats (rmoats)
tags: removed: kilo-backport-potential
Revision history for this message
Ryan Moats (rmoats) wrote :

Once https://bugs.launchpad.net/neutron/+bug/1497450 is addressed, this bug will likely be no longer necessary

Changed in neutron:
assignee: Ryan Moats (rmoats) → Carl Baldwin (carl-baldwin)
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → liberty-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/224323
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3c5cb9d050d09424c3f8eb3cd1ecd6876f50a6fe
Submitter: Jenkins
Branch: master

commit 3c5cb9d050d09424c3f8eb3cd1ecd6876f50a6fe
Author: Carl Baldwin <email address hidden>
Date: Wed Sep 16 21:53:54 2015 +0000

    Only get host data for floating ips on DVR routers

    First, we are only interested in setting the host attribute when
    the router is a DVR router. Second, we don't need to query all of
    the ports on the host, we just need to query the ports that are
    referenced by the set of floating ips that we already have.

    Closes-bug: #1496974
    Change-Id: If611de14b2ab77d2eb9ce8c5b307ea6dd4403fe1

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
Ryan Moats (rmoats) wrote :

Confirmed that this fix addresses the performance issue - Thanks!

Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/233116

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/kilo)

Reviewed: https://review.openstack.org/233116
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=eec8c5021908de76f11087d298572abeb1fe3a21
Submitter: Jenkins
Branch: stable/kilo

commit eec8c5021908de76f11087d298572abeb1fe3a21
Author: Carl Baldwin <email address hidden>
Date: Wed Sep 16 21:53:54 2015 +0000

    Only get host data for floating ips on DVR routers

    First, we are only interested in setting the host attribute when
    the router is a DVR router. Second, we don't need to query all of
    the ports on the host, we just need to query the ports that are
    referenced by the set of floating ips that we already have.

    (cherry picked from commit 3c5cb9d050d09424c3f8eb3cd1ecd6876f50a6fe)

    Closes-bug: #1496974
    Change-Id: If611de14b2ab77d2eb9ce8c5b307ea6dd4403fe1

tags: added: in-stable-kilo
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-rc1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.