ssh driver requirements unclear

[Bob Ball]

The driver requirements for SSH power management are very unclear and need to be extrapolated from existing implementations.

This is particularly an issue for list_running where the code expects to have __quote__ node names, but this is only explained in the code and seems to have been based on a single driver with other drivers having to hack in quotes.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/224770

[Ruby Loo (rloo)]

Thanks for reporting the bug. If I understand correctly from IRC, the bug is that there are some (at least) one driver that returns the node names unquoted, but ironic assumes that they are quoted.

And of course, the lack of documentation.

[Ruby Loo (rloo)]

Oh, what I wanted to mention is that when reporting a bug, it is useful to provide information as to how to reproduce. In this case, might help if you mentioned which driver returned unquoted node names :)

[Bob Ball (bob-ball)]

This was discovered when prototyping a new driver for XenServer; the main frustration was that the requirements were not clear.
The quoted node names for list_running was particularly frustrating as it is non-obvious and enforced by the code.

The bug report was mainly intended to focus on the lack of documentation for the requirements.

XenServer support will be proposed at another time, but I wanted to fix the missing docs since that was an easy change to submit.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/224770
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=335e42931601f5e1f74d28b2d1be2d350fc9dd78
Submitter: Jenkins
Branch: master

commit 335e42931601f5e1f74d28b2d1be2d350fc9dd78
Author: Bob Ball <email address hidden>
Date: Thu Sep 17 15:44:12 2015 +0100

    Handle unquoted node names from virt types

    Not all virt types return node names in quotations when requesting a list of running VMs.
    This should not be a requirement by the code, so relax this restriction and match
    node names without quotes.

    Also, add comments to clarify the expected return value for each of the commands.

    Change-Id: I55a259f8687627a4ebd2d8bb941eb5b1041045c7
    Closes-Bug: #1496867