Shotgun does not save whole of it's log in diagnostic snapshot

[Maciej Kwiek]

When shotgun is creating a snapshot, the shotgun.log within the snapshot will only have the logs from getting objects before the /var/log. The log will be incomplete because it is still being populated while the rest of the snapshot is generated.

Shotgun log should be treated specially and be included in the snapshot as the last object, after all other objects are included.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/248139

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/248139
Committed: https://git.openstack.org/cgit/openstack/shotgun/commit/?id=41fe7aacc6065975a6e563c080c7e5b14e2e9c9b
Submitter: Jenkins
Branch: master

commit 41fe7aacc6065975a6e563c080c7e5b14e2e9c9b
Author: Maciej Kwiek <email address hidden>
Date: Fri Nov 20 16:29:53 2015 +0100

    Dump shotgun log at the end of snapshot creation

    Shotgun dumps /var/log/shotgun.log as normal part of the snapshot, but
    it fills it in as the snapshot is created, which resulted in dumping
    shotgun log split in half.

    This patch makes shotgun dump it's own logs at the end of snapshot
    creation process, just before compressing it.

    Change-Id: Ie3e9737b2f430fd2f6ff3083b216f0ee62681c97
    Closes-Bug: #1496842

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/269583

[Nastya Urlapova (aurlapova)]

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "529"
  build_id: "529"
  fuel-nailgun_sha: "baec8643ca624e52b37873f2dbd511c135d236d9"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "e2d79330d5d708796330fac67722c21f85569b87"
  fuel-ostf_sha: "3bc76a63a9e7d195ff34eadc29552f4235fa6c52"
  fuel-mirror_sha: "fb45b80d7bee5899d931f926e5c9512e2b442749"
  fuelmenu_sha: "e071216cb214e34b4d861478033425ee6a54a3be"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "a365f05b903368225da3fea9aa42afc1d50dc9b4"

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/269583
Committed: https://git.openstack.org/cgit/openstack/shotgun/commit/?id=68812bebd7f4750c63099a5385798e97c31b3c51
Submitter: Jenkins
Branch: master

commit 68812bebd7f4750c63099a5385798e97c31b3c51
Author: Maciej Kwiek <email address hidden>
Date: Tue Jan 19 11:53:37 2016 +0100

    Return error codes other than 1.

    If exception has 'errno' attribute, it is returned instead of '1'.

    Change-Id: I77ef6e91cb5a1ee99dfd3f078e8f7e961ffcf555
    Related-bug: 1496842