Flatten Beziers: raise lower limit for flatness factor to prevent endless loop in python script

Bug #1496804 reported by su_v
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
su_v

Bug Description

Steps to reproduce:
1) launch inkscape
2) draw a curve
3) open 'Extensions > Modify Path > Flatten Beziers'
4) set flatness to 0.0
5) apply

--> the python process is endlessly processing the path with 100% CPU, and never returns control to the main Inkscape process.

Proposed solution:
Raise lower limit in the INX file from '0.0' to '0.1' for the flatness factor.

Additional proposed change:
Move setting the final path data outside the inner loop (AFAICT there's no need to reformat and write 'd' for each step).

Related branches

Revision history for this message
su_v (suv-lp) wrote :
description: updated
summary: - Flatten Beziers: add lower limit to flatness factor to prevent endless
- loop in python script
+ Flatten Beziers: raise lower limit for flatness factor to prevent
+ endless loop in python script
Revision history for this message
Hachmann (marenhachmann) wrote :

Thank you for investigating and fixing! :D

Revision history for this message
jazzynico (jazzynico) wrote :

Fix (and performance improvement...) tested successfully on Xubuntu 15.04 with Inkscape trunk rev. 14380.
Feel free to commit!

Changed in inkscape:
assignee: nobody → ~suv (suv-lp)
importance: Undecided → Low
milestone: none → 0.92
status: New → In Progress
tags: added: backport-proposed
Revision history for this message
su_v (suv-lp) wrote :

@JazzyNico - thanks for testing!

Fix committed to trunk in rev 14381,
backported to lp:inkscape/0.91.x in rev 13786.

Changed in inkscape:
milestone: 0.92 → 0.91.1
status: In Progress → Fix Committed
tags: removed: backport-proposed
jazzynico (jazzynico)
Changed in inkscape:
milestone: 0.91.1 → 0.92
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.