Mistral

task stuck in RUNNING if YAQL expression failed in publish

Bug #1496685 reported by Winson Chan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
High
Winson Chan
Mistral 1.0.0 "liberty"

Bug Description

If there's YAQL expression evaluation error in published variables for any task, the on_action_complete fails, DB transactions rollback, and the task is stuck in a RUNNING state. It should fail the task with appropriate error information.

Nikolay Makhotkin (nmakhotkin)
Changed in mistral:
milestone: none → liberty-rc2
importance: Undecided → High
status: New → Triaged
Winson Chan (winson-c-chan)
Changed in mistral:
assignee: nobody → Winson Chan (winson-c-chan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/225359
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=bf684b6adc93ff44f94cb6b19175bd6fde3df0a8
Submitter: Jenkins
Branch: master

commit bf684b6adc93ff44f94cb6b19175bd6fde3df0a8
Author: Winson Chan <email address hidden>
Date: Fri Sep 18 22:37:34 2015 +0000

    Fail task on publish error

    If there's YAQL expression evaluation error in published variables for
    any task, the on_action_complete fails, DB transactions rollback, and
    the task is stuck in a RUNNING state. This patch sets the task state
    to ERROR and save the error message in the task state_info.

    Change-Id: I9003157f57f4e649610428b046c237f8f51038fb
    Closes-Bug: #1496685

Changed in mistral:
status: Triaged → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-mistralclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/231839

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-mistralclient (master)

Reviewed: https://review.openstack.org/231839
Committed: https://git.openstack.org/cgit/openstack/python-mistralclient/commit/?id=a87923d92f4fd05bcc75c36d8970789dd8005630
Submitter: Jenkins
Branch: master

commit a87923d92f4fd05bcc75c36d8970789dd8005630
Author: Winson Chan <email address hidden>
Date: Tue Sep 29 17:32:53 2015 +0000

    Add state info to tasks list

    When publish fails for a task, the error message will be recorded in
    state info. This patch refactors the task list command to include the
    state info.

    Change-Id: I4a02fb34d7a1f2be3f0a64a808670a35a198f139
    Closes-Bug: #1496685

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/233955

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (stable/liberty)

Reviewed: https://review.openstack.org/233955
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=3ccdedb9a3ca73a6a84fdb909e69f9601815decf
Submitter: Jenkins
Branch: stable/liberty

commit 3ccdedb9a3ca73a6a84fdb909e69f9601815decf
Author: Winson Chan <email address hidden>
Date: Fri Sep 18 22:37:34 2015 +0000

    Fail task on publish error

    If there's YAQL expression evaluation error in published variables for
    any task, the on_action_complete fails, DB transactions rollback, and
    the task is stuck in a RUNNING state. This patch sets the task state
    to ERROR and save the error message in the task state_info.

    Change-Id: I9003157f57f4e649610428b046c237f8f51038fb
    Closes-Bug: #1496685
    (cherry picked from commit bf684b6adc93ff44f94cb6b19175bd6fde3df0a8)

tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-mistralclient (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/234049

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-mistralclient (stable/liberty)

Reviewed: https://review.openstack.org/234049
Committed: https://git.openstack.org/cgit/openstack/python-mistralclient/commit/?id=a1b37c7b9a9c3827e5a7dd0841a4e6b578ae8f2e
Submitter: Jenkins
Branch: stable/liberty

commit a1b37c7b9a9c3827e5a7dd0841a4e6b578ae8f2e
Author: Winson Chan <email address hidden>
Date: Tue Sep 29 17:32:53 2015 +0000

    Add state info to tasks list

    When publish fails for a task, the error message will be recorded in
    state info. This patch refactors the task list command to include the
    state info.

    Change-Id: I4a02fb34d7a1f2be3f0a64a808670a35a198f139
    Closes-Bug: #1496685
    (cherry picked from commit a87923d92f4fd05bcc75c36d8970789dd8005630)

Renat Akhmerov (rakhmerov)
Changed in mistral:
status: Fix Committed → Fix Released
Renat Akhmerov (rakhmerov)
Changed in mistral:
milestone: liberty-rc2 → liberty
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/mistral 2.0.0.0b1

This issue was fixed in the openstack/mistral 2.0.0.0b1 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-mistralclient 1.2.0

This issue was fixed in the openstack/python-mistralclient 1.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.