Network configuration handlers should return object not task

[Aleksey Kasatkin]

Versions: 7.0 and prior.

As for now, network configuration handlers (/clusters/<cluster_id>/network_configuration/neutron/ and /clusters/<cluster_id>/network_configuration/nova_network/) return task objects not network configuration objects. They also return error in those task objects when check_networks or update_network failed while status code for API request remains 200.

Using of tasks in these handlers is not required actually, also they should return actual object instead of task (especially since the task is completed already) and actual request result codes.

[Aleksey Kasatkin (alekseyk-ru)]

These are NeutronNetworkConfigurationHandler and NovaNetworkConfigurationHandler handlers (PUT methods) which should be fixed. CheckNetworks there can be called without creation of Nailgun task. Also, actual networking configuration should be returned.

[Aleksey Kasatkin (alekseyk-ru)]

Correction: class name is NetworkCheck not CheckNetworks.

[Aleksey Kasatkin (alekseyk-ru)]

UI/CLI should be changed accordingly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/232021

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/232021
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=c87470bf9c4fbd622ff443a786b96d8c2dc619b9
Submitter: Jenkins
Branch: master

commit c87470bf9c4fbd622ff443a786b96d8c2dc619b9
Author: Alexander Saprykin <email address hidden>
Date: Wed Oct 7 17:03:53 2015 +0300

    Network configuration handlers return network config

    Change-Id: I6dc259813418de5df4b9fb97f65066b130348b21
    Closes-Bug: #1496630

[Sebastian Kalinowski (prmtl)]

Revert: https://review.openstack.org/238030