hz-magic-search-bar does not honor isServer property
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
In Progress
|
Medium
|
Travis Tripp |
Bug Description
Server side searching and filtering is disrupted by client side smart table filtering. The magic search documentation allows you to set an isServer property for facets. However, ff you set a facet as isServer, smart table filtering will still be done. In the case of wildcards or more advanced searching that is done on the server side which requires server logic, the client side filtering may subsequently wipe out a server response, potentially hiding results, because the client side filtering doesn't understand that the syntax passed to the server will not match content on the client side.
The culprit is that hz-magic-search-bar wraps st-magic-search.
st-magic-search is doing the client side filtering here regardless of the isServer property.
The filterFacets are typically in scope for st-magic-search. If nothing else, it could check the filter facets to see if the isServer property is set on each facet before performing search. Perhaps something like the below:
if (scope.
var isServerFacet = scope.filterFac
return facet.name == predString && facet.isServer;
});
if (isServerFacet) {
return;
}
}
There also should be a way to disable client side full text filtering and allow that to only come from server side (important for searchlight).
Possibly, an attribute on hz-magic-search-bar of client-
description: | updated |
description: | updated |
Changed in horizon: | |
milestone: | next → liberty-rc1 |
Changed in horizon: | |
milestone: | liberty-rc1 → none |
Changed in horizon: | |
assignee: | Rajat Vig (rajatv) → Travis Tripp (travis-tripp) |
Changed in horizon: | |
assignee: | Travis Tripp (travis-tripp) → Rajat Vig (rajatv) |
Changed in horizon: | |
assignee: | Rajat Vig (rajatv) → Travis Tripp (travis-tripp) |
Changed in horizon: | |
assignee: | Travis Tripp (travis-tripp) → Rajat Vig (rajatv) |
Changed in horizon: | |
assignee: | Rajat Vig (rajatv) → Travis Tripp (travis-tripp) |
Fix proposed to branch: master /review. openstack. org/224896
Review: https:/