Test classes/variables are misnamed

Bug #1496568 reported by Ryan Rossiter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
Ryan Rossiter

Bug Description

There is a lot of copy-paste misnames going on in https://github.com/openstack/magnum/blob/master/magnum/tests/unit/conductor/test_template_definition.py and it's very annoying that things like test cases are not named appropriately for the classes they're testing.

Ryan Rossiter (rlrossit)
Changed in magnum:
assignee: nobody → Ryan Rossiter (rlrossit)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/224291

Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/224291
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=a2a19a9f75bab0c7f2a5da3614682f10d572a47c
Submitter: Jenkins
Branch: master

commit a2a19a9f75bab0c7f2a5da3614682f10d572a47c
Author: Ryan Rossiter <email address hidden>
Date: Wed Sep 16 20:36:22 2015 +0000

    Fix naming of variables/classes in tests

    The names of some of the variables had too much copy-paste, and they
    were named k8s even in the mesos and swarm tests. The mesos test was
    also named AtomicMesos* even though it was testing the UbuntuMesos
    template definition class.

    This is super trivial, but staring at these tests made me get irked by
    them a little too much.

    Change-Id: I863c080a8606992a66d7b517b63982da4caf9798
    Closes-Bug: #1496568

Changed in magnum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.